fix(query): modernize CalculationFilterGroup and adjust IsValid behavior #4

Merged
bermudalamb merged 1 commits from fix/Sonarqube-Tech-Debt-v2 into main 2026-05-20 15:32:34 -05:00
1 Commits
Author SHA1 Message Date
Thom Lamb 82af7b8de1 fix(query): modernize CalculationFilterGroup and adjust IsValid behavior
SonarQube Analysis / sonarqube (pull_request) Successful in 3m9s
Refactors the `CalculationFilterGroup` class to utilize C# primary constructors and property initializers, improving conciseness and readability.

The `IsValid()` method's logic is updated. Previously, it returned true if *any* filter in the group was valid. Now, it returns true only if *all* filters are valid, and an empty filter group is considered valid. This adjustment clarifies the group's validity criteria, aligning with common interpretations for `All` operations and addressing related technical debt.
2026-05-20 15:31:41 -05:00