Lambda-Associates/sql-utilities
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(query): modernize CalculationFilterGroup and adjust IsValid behavior #4

Merged
bermudalamb merged 1 commits from fix/Sonarqube-Tech-Debt-v2 into main 2026-05-20 15:32:34 -05:00
Conversation 0 Commits 1 Files Changed 2
+9 -15
bermudalamb commented 2026-05-20 15:32:20 -05:00
Owner
Copy Link
Copy Source

Refactors the CalculationFilterGroup class to utilize C# primary constructors and property initializers, improving conciseness and readability.

The IsValid() method's logic is updated. Previously, it returned true if any filter in the group was valid. Now, it returns true only if all filters are valid, and an empty filter group is considered valid. This adjustment clarifies the group's validity criteria, aligning with common interpretations for All operations and addressing related technical debt.

Refactors the `CalculationFilterGroup` class to utilize C# primary constructors and property initializers, improving conciseness and readability. The `IsValid()` method's logic is updated. Previously, it returned true if *any* filter in the group was valid. Now, it returns true only if *all* filters are valid, and an empty filter group is considered valid. This adjustment clarifies the group's validity criteria, aligning with common interpretations for `All` operations and addressing related technical debt.
bermudalamb added 1 commit 2026-05-20 15:32:21 -05:00
fix(query): modernize CalculationFilterGroup and adjust IsValid behavior
SonarQube Analysis / sonarqube (pull_request) Successful in 3m9s
Details
82af7b8de1 
Refactors the `CalculationFilterGroup` class to utilize C# primary constructors and property initializers, improving conciseness and readability.

The `IsValid()` method's logic is updated. Previously, it returned true if *any* filter in the group was valid. Now, it returns true only if *all* filters are valid, and an empty filter group is considered valid. This adjustment clarifies the group's validity criteria, aligning with common interpretations for `All` operations and addressing related technical debt.
bermudalamb merged commit df1805a402 into main 2026-05-20 15:32:34 -05:00
bermudalamb deleted branch fix/Sonarqube-Tech-Debt-v2 2026-05-20 15:32:36 -05:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
bermudalamb (Thom Lamb)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Lambda-Associates/sql-utilities#4