bermudalamb
332c1e7cd0
SonarQube reported 0% coverage for 78 unit, 134 integration and 83 end-to-end tests, so the coverage-on-new-code gate — the most useful thing SonarQube offers a project this size — has been failing permanently while looking configured. It now reports 69.6%, verified by a real scan. Backend coverage comes from both suites, written to separate directories because jest writes coverage/lcov.info by default and the second run would silently overwrite the first. Both are needed rather than just the fast one: the unit suite alone reports 11%, because everything in src/routes is exercised by the integration suite. That suite is manual-only after hanging for 3h12m post-run, so it runs here with --forceExit and the job carries a hard timeout; jest confirmed during testing that it would otherwise have hung. The frontend had no unit tests at all, so its coverage comes from Playwright driving an istanbul-instrumented dev server, collected per test by an auto-fixture and merged with nyc. The 17 specs now import from a local fixtures module that re-exports @playwright/test, which is what lets the fixture attach without touching each test body. Instrumentation is gated behind COVERAGE=true and loaded by dynamic import, since vite-plugin-istanbul is ESM-only while vite.config.ts evaluates as CommonJS. Both directions were checked rather than assumed: a normal build contains no instrumentation, and the dev server instruments nested modules as well as top-level ones — the first attempt used an include glob of src/* which would have silently missed everything under src/admin and src/cart. coverage:report fails when nothing was collected instead of writing an empty report, and that guard was fired deliberately to confirm it works. This project has been bitten twice by tools succeeding while measuring nothing — SonarQube skipping the whole frontend and still exiting EXECUTION SUCCESS in #67, and an ESLint matcher silently matching no files during #60 — and coverage has exactly that shape: an uninstrumented dev server lets every test pass while gathering nothing, and the 0% that follows reads as lost coverage rather than broken collection. Worth knowing when reading the numbers: end-to-end coverage flatters. Istanbul marks a line covered when the browser ran it, so a component rendered during a test counts as covered with nothing asserting anything about it. Recorded in the design doc and the project context rather than left to be discovered. Also declares sonar.tests so test files are analysed under the test rule set rather than as production code. Closes #61
76 lines
3.1 KiB
TypeScript
76 lines
3.1 KiB
TypeScript
import { test, expect } from './fixtures';
|
|
|
|
const suffix = () => `s${Date.now().toString(36)}${Math.random().toString(36).slice(2, 7)}`;
|
|
|
|
test.describe('Admin save failures', () => {
|
|
test('does not claim an item was saved when the request failed', async ({ page }) => {
|
|
await page.route('**/api/admin/items', (route) => {
|
|
if (route.request().method() === 'POST') {
|
|
return route.fulfill({
|
|
status: 500,
|
|
contentType: 'application/json',
|
|
body: '{"error":"internal error"}'
|
|
});
|
|
}
|
|
return route.continue();
|
|
});
|
|
|
|
await page.goto('/admin');
|
|
await page.getByRole('button', { name: 'Add Item' }).click();
|
|
await page.getByLabel('Name').fill(`Broken ${suffix()}`);
|
|
await page.getByLabel('Price (USD)').fill('12');
|
|
await page.getByRole('button', { name: 'OK' }).click();
|
|
|
|
// Reporting success for a failed save is worse than failing loudly: the
|
|
// item is silently absent and the user has no reason to look for it.
|
|
await expect(page.getByText('Item added')).toBeHidden();
|
|
await expect(page.getByText("Couldn't save item")).toBeVisible();
|
|
// The form must stay open so the entered values aren't lost.
|
|
await expect(page.getByRole('dialog')).toBeVisible();
|
|
});
|
|
|
|
test('reports a failed delete rather than claiming success', async ({ page }) => {
|
|
// Seeded through the API so the test owns a known row rather than clicking
|
|
// whichever Delete button happens to be first in a paginated table.
|
|
const name = `Doomed ${suffix()}`;
|
|
const created = await page.request.post('/api/admin/items', {
|
|
multipart: { name, description: '', price: '10', category_id: '', tags: '[]' }
|
|
});
|
|
expect(created.ok()).toBeTruthy();
|
|
|
|
await page.route('**/api/admin/items/*', (route) => {
|
|
if (route.request().method() === 'DELETE') {
|
|
return route.fulfill({ status: 500, contentType: 'application/json', body: '{"error":"nope"}' });
|
|
}
|
|
return route.continue();
|
|
});
|
|
|
|
await page.goto('/admin');
|
|
// Items list newest-first, so the seeded row is on the first page.
|
|
const row = page.getByRole('row').filter({ hasText: name });
|
|
await expect(row).toBeVisible();
|
|
await row.getByRole('button', { name: 'Delete' }).click();
|
|
|
|
await expect(page.getByText('Item deleted')).toBeHidden();
|
|
await expect(page.getByText("Couldn't delete item")).toBeVisible();
|
|
// The row must survive a failed delete.
|
|
await expect(row).toBeVisible();
|
|
});
|
|
|
|
test('saves an item successfully when the server accepts it', async ({ page }) => {
|
|
const name = `Good ${suffix()}`;
|
|
|
|
await page.goto('/admin');
|
|
await page.getByRole('button', { name: 'Add Item' }).click();
|
|
await page.getByLabel('Name').fill(name);
|
|
await page.getByLabel('Price (USD)').fill('34');
|
|
await page.getByRole('button', { name: 'OK' }).click();
|
|
|
|
await expect(page.getByText('Item added')).toBeVisible();
|
|
|
|
// Confirm the row actually reached the database, not just that a toast fired.
|
|
const items = await (await page.request.get('/api/admin/items')).json();
|
|
expect(items.some((item: { name: string }) => item.name === name)).toBeTruthy();
|
|
});
|
|
});
|