bermudalamb
9b3a03d1bf
storefront, storefront-errors, theme, error-boundary and filters. filters.spec.ts carried the last hand-rolled copies of createCategory, createTag and createItem, and the hardcoded `http://localhost:5173` that meant changing the port in the config would have moved every test except this one. Seeding now goes through support/api, and the host it needs lives in one constant. It has to be a constant rather than the config's baseURL: beforeAll runs with worker-scoped fixtures only and cannot read a test-scoped option, which is why the URL was inlined there in the first place. New FilterDrawer object. The two rules it encodes are the ones the tests exist to pin down and neither is guessable from a locator: categories are a tree because the filter matches a node and everything filed beneath it, and tags combine with AND rather than OR, so selecting two means "must have both". The active-filter chips go on StorefrontPage rather than the drawer, because that is where they render — and the scoping matters, since the drawer carries a "Clear all" of its own that an unscoped locator also matches. StorefrontPage gains the three things the catalogue says instead of listing items. They are named together deliberately: the distinction between "No items yet" and "Couldn't load items" is the point, and several tests assert one is showing while the other is not, because telling a customer the shop is empty when the server is broken hides the outage. The theme switch and the attribute it writes are both on Header now. The switch is in the header and `data-theme` lands on <body>, so a spec previously had to know about `body` to observe the control it had just clicked. Verified: 12/12 across the four small specs, 8/8 on filters, tsc clean, lint unchanged at the 30-warning src baseline. Refs #137
52 lines
1.7 KiB
TypeScript
52 lines
1.7 KiB
TypeScript
import { test, expect } from './fixtures';
|
|
|
|
test.describe('Storefront failure states', () => {
|
|
test('reports a server failure instead of claiming the store is empty', async ({
|
|
page,
|
|
storefront
|
|
}) => {
|
|
await page.route('**/api/items*', (route) =>
|
|
route.fulfill({ status: 500, contentType: 'application/json', body: '{"error":"internal error"}' })
|
|
);
|
|
|
|
await storefront.goto();
|
|
|
|
// Telling a customer "no items yet" when the server is broken is worse than
|
|
// saying nothing — it reads as an empty catalogue and hides the outage.
|
|
await expect(storefront.emptyNotice).toBeHidden();
|
|
await expect(storefront.loadFailureNotice).toBeVisible();
|
|
await expect(storefront.retryButton).toBeVisible();
|
|
});
|
|
|
|
test('recovers when the server comes back', async ({ page, storefront }) => {
|
|
let failing = true;
|
|
await page.route('**/api/items*', (route) => {
|
|
if (failing) {
|
|
return route.fulfill({ status: 500, contentType: 'application/json', body: '{"error":"internal error"}' });
|
|
}
|
|
return route.continue();
|
|
});
|
|
|
|
await storefront.goto();
|
|
await expect(storefront.retryButton).toBeVisible();
|
|
|
|
failing = false;
|
|
await storefront.retryButton.click();
|
|
|
|
await expect(storefront.loadFailureNotice).toBeHidden();
|
|
});
|
|
|
|
test('a request that never resolves does not render as an empty catalogue', async ({
|
|
page,
|
|
storefront
|
|
}) => {
|
|
// Mirrors the real incident: an un-migrated database left every item query
|
|
// hanging with no response at all.
|
|
await page.route('**/api/items*', () => { /* never fulfilled */ });
|
|
|
|
await storefront.goto();
|
|
|
|
await expect(storefront.emptyNotice).toBeHidden();
|
|
});
|
|
});
|