Feature/63 admin gate #94

2026-08-21T13:42:17-05:00

bermudalamb commented

2026-08-21 13:42:17 -05:00

No description provided.

bermudalamb self-assigned this 2026-08-21 13:42:17 -05:00

bermudalamb added this to the Code Quality and Hardening project 2026-08-21 13:42:17 -05:00

bermudalamb added 2 commits 2026-08-21 13:42:22 -05:00

feat(backend): add an application-layer gate to the admin API (#63 ) 3374d093f0

Authorization for the admin panel and the admin API has lived entirely in one auth_request regex in an Nginx Proxy Manager config outside this repository. That control is real and it works — nothing is publicly exposed today — but it is invisible from the code, untested here, and not reviewed when this code changes. Three things follow from that, and the first is the one worth the change.

An admin route added at a path the regex does not match is unprotected the moment it is written, and nothing in Express indicates that. Anything reaching the published container port directly bypasses authentik entirely. And locally there is no gate at all, so no developer ever sees the boundary being enforced.

requireAdminGate is attached to each admin router rather than to a path prefix, which is what makes it useful rather than merely redundant with the proxy. An admin router added later at some other path inherits the gate; because the proxy only injects the header on paths its regex matches, that router refuses on its first request instead of being quietly public. A 403 in that situation is the boundary reporting that it has drifted.

The gate is optional, and unset means exactly today's behaviour. That keeps local development and all 113 existing admin test call sites working untouched, and means shipping the image before configuring the proxy cannot take the admin panel down. What it does not do is stay silent about it: the server warns at boot when the gate is inactive, naming what is unprotected. This project has been bitten repeatedly by controls that report success while doing nothing, and an unconfigured gate should be a visible choice rather than an invisible one.

An empty value is treated as unset rather than as a secret, because enforcing an empty secret would admit any caller sending an empty header. Comparison is timing-safe over SHA-256 digests of both sides: timingSafeEqual throws on buffers of unequal length, so comparing raw values would turn a short header into a 500 rather than a 403, and a length check first would leak the secret's length.

Turning it on requires the secret in two places at once — the stack environment and a proxy_set_header line on the gated location in NPM. Setting only one gives 403s until the other catches up. That coupling, and the three consequences above, are now written into the README beside the deployment section, since none of it is visible from the code.

Verified over real HTTP as well as in tests. Booting without the secret logs the warning and serves admin normally; booting with it returns 403 for a missing header, 403 for a wrong one, 200 for the right one, and leaves the public storefront at 200 throughout, with each refusal logged distinguishably and without echoing the value it was sent. 8 new unit tests, 9 new integration tests covering every admin router separately — a correct middleware nobody mounted would pass the unit tests and protect nothing. 106 unit and 153 integration passing, lint 0 errors and 8 warnings unchanged.

Refs #63
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

Merge branch 'main' into feature/63-admin-gate

SonarQube Analysis / sonarqube (pull_request) Failing after 23m58s

Details

Tests / lint (pull_request) Successful in 4m27s

Details

Tests / backend-unit (pull_request) Successful in 1m38s

Details

Tests / frontend-e2e (pull_request) Failing after 35m2s

Details

fcee4d0faa

bermudalamb merged commit 984d91f00a into main

2026-08-21 13:44:16 -05:00

bermudalamb deleted branch feature/63-admin-gate

2026-08-21 13:44:16 -05:00

bermudalamb moved this to Review in Code Quality and Hardening on 2026-08-21 13:45:34 -05:00

bermudalamb moved this to Ready for Release in Code Quality and Hardening on 2026-08-21 13:54:52 -05:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: bermudalamb/redefined-designs#94