bermudalamb/redefined-designs
1
0
Fork 0
Code Issues 2 Pull Requests 1 Actions Packages Projects 3 Releases Wiki Activity

fix: bound admin image uploads and use a CSPRNG for stored filenames #4

Merged
bermudalamb merged 1 commits from fix/sonarqube-upload-limits-and-weak-rng into main 2026-08-14 09:26:00 -05:00
Conversation 0 Commits 1 Files Changed 1
+40 -5
1 Commits
Author SHA1 Message Date
bermudalambandClaude Opus 5 aba47c81e3 fix: bound admin image uploads and use a CSPRNG for stored filenames
SonarQube Analysis / sonarqube (pull_request) Successful in 3m49s
Details
Tests / backend-unit (pull_request) Successful in 33s
Details
Tests / backend-integration (pull_request) Successful in 1m6s
Details
Tests / frontend-e2e (pull_request) Failing after 1m7s
Details 
SonarQube flagged three hotspots in the admin router: multer was
configured with no content length limits, and stored filenames were
derived from Date.now() plus Math.random().

- Cap the multipart body on every dimension: 6 files, 8 MiB per image,
  8 fields, 64 KiB per field. Without limits a single request could
  fill the uploads volume.
- Generate stored filenames with crypto.randomUUID() so paths are not
  predictable. Image ordering is unaffected; sort_order already drives it.
- Wrap the upload middleware to translate MulterError into 413/400 JSON.
  The app mounts no error handler, so a limit rejection would otherwise
  surface as an HTML 500.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
 2026-08-14 09:22:45 -05:00