bermudalamb/redefined-designs
1
0
Fork 0
Code Issues 2 Pull Requests 1 Actions Packages Projects 3 Releases Wiki Activity

test: disambiguate the Email locator in auth.spec #22

Merged
bermudalamb merged 1 commits from fix/auth-spec-email-locator into main 2026-08-15 18:37:39 -05:00
Conversation 0 Commits 1 Files Changed 1
+3 -3
bermudalamb commented 2026-08-15 18:37:21 -05:00
Owner
Copy Link
Copy Source

getByLabel('Email') matched two elements on /register -- the email input and
the marketing consent checkbox, whose label "Send me occasional emails"
contains the substring. Playwright's strict mode failed both tests that
filled it.

getByRole('textbox', ...) narrows by role, so the checkbox no longer collides.
Applied to the /login usage too, so the same concept reads the same way
throughout the file.

These failures were latent: the frontend-e2e job died at the build step
before it ever reached the tests, so CI never reported them.

Co-Authored-By: Claude Opus 5 (1M context) noreply@anthropic.com

getByLabel('Email') matched two elements on /register -- the email input and the marketing consent checkbox, whose label "Send me occasional emails" contains the substring. Playwright's strict mode failed both tests that filled it. getByRole('textbox', ...) narrows by role, so the checkbox no longer collides. Applied to the /login usage too, so the same concept reads the same way throughout the file. These failures were latent: the frontend-e2e job died at the build step before it ever reached the tests, so CI never reported them. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
bermudalamb added 1 commit 2026-08-15 18:37:23 -05:00
test: disambiguate the Email locator in auth.spec
SonarQube Analysis / sonarqube (pull_request) Successful in 5m18s
Details
Tests / backend-unit (pull_request) Successful in 51s
Details
Tests / backend-integration (pull_request) Successful in 3m25s
Details
Tests / frontend-e2e (pull_request) Successful in 12m21s
Details
a240d86762 
getByLabel('Email') matched two elements on /register -- the email input and
the marketing consent checkbox, whose label "Send me occasional emails"
contains the substring. Playwright's strict mode failed both tests that
filled it.

getByRole('textbox', ...) narrows by role, so the checkbox no longer collides.
Applied to the /login usage too, so the same concept reads the same way
throughout the file.

These failures were latent: the frontend-e2e job died at the build step
before it ever reached the tests, so CI never reported them.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
bermudalamb merged commit cd07f9a1c5 into main 2026-08-15 18:37:39 -05:00
bermudalamb deleted branch fix/auth-spec-email-locator 2026-08-15 18:37:41 -05:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
calamb (Chelsea Lamb) bermudalamb (Thom Lamb)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: bermudalamb/redefined-designs#22