fix: unset NODE_ENV in e2e job so devDependencies install #19

Merged

bermudalamb merged 2 commits from fix/e2e-devdeps-and-summarize into main 2026-08-15 08:56:27 -05:00

Conversation 0 Commits 2 Files Changed 3

+64 -19

bermudalamb commented 2026-08-15 08:55:45 -05:00

Owner

Copy Link

Copy Source

npm treats NODE_ENV=production as --omit=dev, so npm install in the
frontend-e2e job skipped typescript and the build died on tsc: not found.
The same env var would have stripped vite and @playwright/test from the
frontend install, and flipped the session cookie to Secure on a run served
over plain http.

The reported summarize crash was a symptom: the job aborted before Playwright
ran, but Summarize is if: always() and threw ENOENT on the missing JSON,
burying the real failure. Both summarize scripts now report the missing file
and exit 0 -- the job still fails via its own step.

Also split build from start, replaced sleep 3 with a readiness poll against
/api/config, and dump the backend log when e2e fails.

Co-Authored-By: Claude Opus 5 (1M context) noreply@anthropic.com

npm treats NODE_ENV=production as --omit=dev, so `npm install` in the frontend-e2e job skipped typescript and the build died on `tsc: not found`. The same env var would have stripped vite and @playwright/test from the frontend install, and flipped the session cookie to Secure on a run served over plain http. The reported summarize crash was a symptom: the job aborted before Playwright ran, but Summarize is `if: always()` and threw ENOENT on the missing JSON, burying the real failure. Both summarize scripts now report the missing file and exit 0 -- the job still fails via its own step. Also split build from start, replaced `sleep 3` with a readiness poll against /api/config, and dump the backend log when e2e fails. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

bermudalamb added 1 commit 2026-08-15 08:55:46 -05:00

fix: unset NODE_ENV in e2e job so devDependencies install ... abebb3eb9b

npm treats NODE_ENV=production as --omit=dev, so `npm install` in the
frontend-e2e job skipped typescript and the build died on `tsc: not found`.
The same env var would have stripped vite and @playwright/test from the
frontend install, and flipped the session cookie to Secure on a run served
over plain http.

The reported summarize crash was a symptom: the job aborted before Playwright
ran, but Summarize is `if: always()` and threw ENOENT on the missing JSON,
burying the real failure. Both summarize scripts now report the missing file
and exit 0 -- the job still fails via its own step.

Also split build from start, replaced `sleep 3` with a readiness poll against
/api/config, and dump the backend log when e2e fails.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

bermudalamb added 1 commit 2026-08-15 08:56:15 -05:00

Merge branch 'main' into fix/e2e-devdeps-and-summarize d87179363e

bermudalamb merged commit e7fb7271f0 into main 2026-08-15 08:56:27 -05:00

bermudalamb deleted branch fix/e2e-devdeps-and-summarize 2026-08-15 08:56:33 -05:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

No items

No labels

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

calamb (Chelsea Lamb) bermudalamb (Thom Lamb)

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: bermudalamb/redefined-designs#19