Feature/188 filter dimensions #189

2026-08-25T16:24:52-05:00

bermudalamb commented

2026-08-25 16:24:52 -05:00

No description provided.

bermudalamb self-assigned this 2026-08-25 16:24:52 -05:00

bermudalamb added this to the Customer and Admin UI review findings project 2026-08-25 16:24:52 -05:00

bermudalamb added 13 commits 2026-08-25 16:24:53 -05:00

docs(design): filter dimensions, one composable component both screens extend (#188 ) 20a38b66bd

#169 made the filter drawer shared, which was the right first move and not the finish. Per-screen differences are booleans, the bar around the drawer was never shared at all, and the storefront's availability preset sits outside the system because the shared component cannot express "this belongs in the bar, not the drawer".

The design replaces the flags with composition: a screen contributes a list of filter dimensions, each declaring where it renders, how to render it, and what chips it contributes. A screen-specific control becomes an ordinary dimension, appearing in the chip row and counting toward the tally without the shared code knowing what it is.

Dimensions are plain data rather than components or context, for a concrete reason rather than a stylistic one. The drawer sets destroyOnHidden, so its sections are unmounted whenever it is closed — exactly when the chip row matters most. Anything that registers on mount would lose those chips the moment the drawer closed, which rules out the otherwise-idiomatic context-and-children approach.

The tally becomes the number of chips, so the count and the chip row cannot disagree — today they are computed by two routes and agree by coincidence, which the admin already has to correct by hand. Three visible behaviours change as a result, recorded in the spec rather than left to be discovered.

Adding vitest is in scope. The design's value rests on chips() being pure, and the frontend has no unit runner at all, so without one the core of it would ship covered only indirectly and expensively through Playwright.

The spec also records what is deliberately untouched: the filter state, the URL serialisation, the backend, and the two e2e assertions already failing on #186 — which must not be read as regressions from this work.

Refs #188

docs(plan): implementation plan for filter dimensions (#188 ) e695d91670

Nine tasks, each ending in something independently testable, in an order where every task leaves both screens working. The dimensions are built and unit-tested first, the shell after them, and the two screens are wired last — so the old components stay in place until the thing replacing them is proven.

The two behaviour changes the design accepted are each covered twice: a unit test on the chips that produce them, and an end-to-end assertion on what a person sees. The admin tally reading three for three statuses, and a non-default availability producing a removable chip.

Task 8 carries the deletions, deliberately last. Removing `activeFilterCount` and `hasActiveFilters` turns every remaining caller into a compile error, which is the cheapest way to find them.

Two defects found reviewing the plan against the code rather than against itself: the test fixture omitted `Category.item_count` and would not have compiled, and Task 9 added a page object method that nothing used — `chooseAvailability` and `filterChip` already exist.

The plan also records what must not be read as a regression. Two assertions in the storefront specs fail on every branch because the unpaginated grid cannot render 1,600+ development rows inside Playwright's default timeout, which is #186 and predates this work.

Refs #188

test(filters): add a unit runner and the filter dimension contract (#188 ) 5d0b66a982

feat(filters): add tag and price dimensions (#188 ) abd3dd4e2e

docs(plan): correct the cumulative unit test counts (#188 ) 60b76cae82

Task 1 leaves 4 tests and Task 2 adds 7, so the running total is 11 rather than 12, and the same off-by-one carried into Tasks 3, 4 and the completion criteria. Caught by the Task 2 implementer, which flagged the mismatch rather than inventing a test to reach the stated number.

feat(filters): add favorites and status dimensions (#188 ) eb5799dd17

feat(filters): move the availability preset into a bar dimension (#188 ) 1d7f928c48

refactor(filters): extract the chip row from ActiveFilterChips (#188 ) 918d6eeab9

feat(filters): add FilterBar, one component both screens compose (#188 ) 50d048a1d6

refactor(admin): compose the inventory filters from dimensions (#188 ) 2f0da9afe1

refactor(filters): compose the storefront from dimensions and delete the old components (#188 ) 147e280f88

Replaces App.tsx's hand-written Segmented/Filters-button/ActiveFilterChips
region with a single FilterBar composed from five dimensions, and removes
the FilterDrawer and ActiveFilterChips components along with the
activeFilterCount and hasActiveFilters helpers they were the only callers
of. Catalogue now receives a filtered boolean computed the same way
FilterBar computes its own chip tally, rather than the ItemFilters object
it only ever used for that one check.

test(filters): cover the tally and availability chip behaviour changes (#188 ) 8771deeaca

fix(filters): address the final review findings (#188 )

SonarQube Analysis / sonarqube (pull_request) Failing after 20m36s

Details

Linting / lint (pull_request) Successful in 2m7s

Details

3242018782

Restores the escape hatch for a status list matching no preset. filtersFromSearchParams accepts any non-empty subset of {available, reserved, sold}, and only three of those seven lists are presets; the other four reported as the not-sold fallback and produced no chip, so ?status=reserved was an empty grid reading "No items yet - check back soon" with no Clear filters button and no way out but editing the URL. hasActiveFilters covered all seven before this branch, so that was a regression against main. availabilityDimension now emits a chip for any status that is not the not-sold preset, labelled from SALE_STATE_LABELS when the list matches one and from statusLabel when it does not. The Segmented still reads "Not sold" beside such a chip, which is a cosmetic wart and the cheaper half of the trade.

Runs the frontend unit suite in CI. The 22 tests added over the dimensions were invoked by nothing: the workflow's only frontend steps were the build and the end-to-end run, and its test:unit:cov step is the backend's. The new step is guarded and named in the gate like every other suite, per the invariant workflowGate.test.ts asserts.

Restores the comment explaining why availabilityDimension's render and chips pass different fallbacks to saleStateFromStatuses. The control must read "All" while sold favorites are on screen; chips must stay silent because the customer never chose it. Unifying them would give every signed-in favorites view a phantom All chip and a tally of 2, and nothing said so after the old markup was deleted.

Derives the storefront's "is anything filtered" and FilterBar's tally through one exported chipsFor rather than two expressions over two identically-built contexts. They agreed only by convention, which is the exact defect this branch exists to remove.

Documents that statusDimension and availabilityDimension are alternatives over one field, since composing both type-checks and would render two controls that double-count it, and asserts the price chip's label text, which was the only chip label nothing checked.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

bermudalamb merged commit f5e3ec3e99 into main

2026-08-25 16:25:22 -05:00

bermudalamb deleted branch feature/188-filter-dimensions

2026-08-25 16:25:22 -05:00

bermudalamb moved this to In Progress in Customer and Admin UI review findings on 2026-08-25 16:27:17 -05:00

bermudalamb moved this to Review in Customer and Admin UI review findings on 2026-08-26 08:10:14 -05:00

bermudalamb moved this to Ready for Release in Customer and Admin UI review findings on 2026-09-09 13:33:36 -05:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: bermudalamb/redefined-designs#189