Files
sql-utilities/tests/Strata.SqlTools.Markdown.Tests/SqlServer/QueryBreakdownGeneratorTests.cs
T
Thom LambandClaude Opus 4.7 6175dcde96
SonarQube Analysis / sonarqube (pull_request) Successful in 2m50s
chore(sonar)!: cascade CA1822 through Markdown dialect wrappers
Commit 5202d93 made the SqlServer-namespaced Markdown generator methods
static, which left the LinqToSql / PostgreSql / Snowflake wrapper
classes' instance methods delegating to nothing but a static call.
SonarQube re-flagged those 10 wrapper methods as CA1822 on the next
scan.

This sweep:

- Makes all 10 wrapper instance methods `static` (`dotnet format` driven).
- Makes `Markdown.LinqToSql.QueryBreakdownGenerator.GenerateCombinedDiagram`
  static preemptively — it composes two static helpers and would otherwise
  be the next-iteration cascade flag.
- Removes the now-dead `_baseGenerator` field and its initializing
  constructor from all six dialect wrappers (LinqToSql / PostgreSql /
  Snowflake × QueryBreakdownGenerator + SqlStatementGenerator). The
  classes keep their implicit parameterless constructor so `new
  Snowflake.QueryBreakdownGenerator()` still compiles.
- Updates the one test call site (`GenerateCombinedDiagram`) the fixer
  didn't catch to use type-name form.

BREAKING CHANGE: External NuGet consumers calling
`instance.Generate*Diagram(...)` on `Markdown.LinqToSql.*`,
`Markdown.PostgreSql.*`, or `Markdown.Snowflake.*` generators must
switch to type-name form, e.g. `Markdown.Snowflake.SqlStatementGenerator.GenerateSequenceDiagram(...)`.
The class types and parameterless constructors remain — only the call
syntax for these methods changes.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-27 14:38:58 -05:00

155 lines
4.7 KiB
C#

using Strata.SqlTools.Breakdowns.SqlServer;
using Strata.SqlTools.Markdown.SqlServer;
using Interfaces = Strata.SqlTools.SqlBreakdown.Interfaces;
namespace Strata.SqlTools.Markdown.Tests.SqlServer;
[TestFixture]
public class QueryBreakdownGeneratorTests
{
private QueryBreakdownGenerator _generator = null!;
[SetUp]
public void Setup()
{
_generator = new QueryBreakdownGenerator();
}
[Test]
public void GenerateMermaidDiagram_WithSimpleQuery_GeneratesFlowchart()
{
// Arrange
var query = new QueryBreakdown("ID, Name", "Users");
// Act
var result = QueryBreakdownGenerator.GenerateMermaidDiagram(query);
// Assert
Assert.That(result, Does.Contain("```mermaid"));
Assert.That(result, Does.Contain("flowchart TD"));
Assert.That(result, Does.Contain("SELECT"));
Assert.That(result, Does.Contain("FROM"));
Assert.That(result, Does.Contain("```"));
}
[Test]
public void GenerateMermaidDiagram_WithComplexQuery_IncludesAllClauses()
{
// Arrange
var query = new QueryBreakdown(
"u.ID, u.Name, COUNT(o.OrderID) as OrderCount",
"Users u JOIN Orders o ON u.ID = o.UserID",
"u.Active = 1"
);
query.GroupByClause.Clause = "u.ID, u.Name";
query.HavingClause.Clause = "COUNT(o.OrderID) > 5";
query.OrderByClause.Clause = "OrderCount DESC";
// Act
var result = QueryBreakdownGenerator.GenerateMermaidDiagram(query, "User Orders Query");
// Assert
Assert.That(result, Does.Contain("### User Orders Query"));
Assert.That(result, Does.Contain("SELECT"));
Assert.That(result, Does.Contain("FROM"));
Assert.That(result, Does.Contain("WHERE"));
Assert.That(result, Does.Contain("GROUP BY"));
Assert.That(result, Does.Contain("HAVING"));
Assert.That(result, Does.Contain("ORDER BY"));
}
[Test]
public void GenerateMermaidDiagram_WithWhereClause_UsesDecisionShape()
{
// Arrange
var query = new QueryBreakdown("*", "Products", "Price > 100");
// Act
var result = QueryBreakdownGenerator.GenerateMermaidDiagram(query);
// Assert
Assert.That(result, Does.Contain("WHERE"));
Assert.That(result, Does.Contain("{"));
Assert.That(result, Does.Contain("}"));
}
[Test]
public void GenerateMermaidDiagram_ParsedQuery_GeneratesDiagram()
{
// Arrange
var sql = @"
SELECT u.ID, u.Name, u.Email
FROM Users u
WHERE u.Active = 1
ORDER BY u.Name";
var query = QueryBreakdown.Parse(sql);
// Act
var result = QueryBreakdownGenerator.GenerateMermaidDiagram(query);
// Assert
Assert.That(result, Is.Not.Null);
Assert.That(result, Does.Contain("mermaid"));
Assert.That(result, Does.Contain("SELECT"));
Assert.That(result.Length, Is.GreaterThan(100));
}
[Test]
public void GenerateMermaidDiagram_WithTitle_IncludesTitle()
{
// Arrange
var query = new QueryBreakdown("*", "Users");
// Act
var result = QueryBreakdownGenerator.GenerateMermaidDiagram(query, "Test Query");
// Assert
Assert.That(result, Does.StartWith("### Test Query"));
}
[Test]
public void GenerateMermaidDiagram_WithoutTitle_NoTitle()
{
// Arrange
var query = new QueryBreakdown("*", "Users");
// Act
var result = QueryBreakdownGenerator.GenerateMermaidDiagram(query);
// Assert
Assert.That(result, Does.Not.StartWith("###"));
Assert.That(result, Does.StartWith("```mermaid"));
}
[Test]
public void GenerateMermaidDiagram_WithLongClause_TruncatesText()
{
// Arrange
var longSelect = string.Join(", ", Enumerable.Range(1, 50).Select(i => $"Column{i}"));
var query = new QueryBreakdown(longSelect, "LargeTable");
// Act
var result = QueryBreakdownGenerator.GenerateMermaidDiagram(query);
// Assert
Assert.That(result, Does.Contain("..."));
}
[Test]
public void GenerateMermaidDiagram_ISqlBreakdown_GeneratesSimpleDiagram()
{
// Arrange
var query = new QueryBreakdown("*", "Users");
query.SetupClauses.Add("CREATE TEMP TABLE #Temp (ID INT)");
// Act
var result = QueryBreakdownGenerator.GenerateMermaidDiagram((Interfaces.ISqlBreakdown)query);
// Assert
Assert.That(result, Does.Contain("mermaid"));
Assert.That(result, Does.Contain("flowchart TD"));
Assert.That(result, Does.Contain("Users"));
}
}