chore(sonar)!: production-code cleanup — S1168 GetQuery + CA1822 static methods #15

Merged

bermudalamb merged 5 commits from fix/sonarqube-prod-s1168-ca1822 into main 2026-05-27 14:54:06 -05:00

Conversation 0 Commits 5 Files Changed 25

+129 -201

5 Commits

Author	SHA1	Message	Date
Thom LambandClaude Opus 4.7	6175dcde96	chore(sonar)!: cascade CA1822 through Markdown dialect wrappers ... Commit 5202d93 made the SqlServer-namespaced Markdown generator methods static, which left the LinqToSql / PostgreSql / Snowflake wrapper classes' instance methods delegating to nothing but a static call. SonarQube re-flagged those 10 wrapper methods as CA1822 on the next scan. This sweep: - Makes all 10 wrapper instance methods `static` (`dotnet format` driven). - Makes `Markdown.LinqToSql.QueryBreakdownGenerator.GenerateCombinedDiagram` static preemptively — it composes two static helpers and would otherwise be the next-iteration cascade flag. - Removes the now-dead `_baseGenerator` field and its initializing constructor from all six dialect wrappers (LinqToSql / PostgreSql / Snowflake × QueryBreakdownGenerator + SqlStatementGenerator). The classes keep their implicit parameterless constructor so `new Snowflake.QueryBreakdownGenerator()` still compiles. - Updates the one test call site (`GenerateCombinedDiagram`) the fixer didn't catch to use type-name form. BREAKING CHANGE: External NuGet consumers calling `instance.Generate*Diagram(...)` on `Markdown.LinqToSql.*`, `Markdown.PostgreSql.*`, or `Markdown.Snowflake.*` generators must switch to type-name form, e.g. `Markdown.Snowflake.SqlStatementGenerator.GenerateSequenceDiagram(...)`. The class types and parameterless constructors remain — only the call syntax for these methods changes. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-27 14:38:58 -05:00
Thom Lambandbermudalamb	3ba7a7e9f3	refactor(linq): extract GetEmptyQueryable<T> helper for empty-return paths ... DRYs the four `Enumerable.Empty<T>().AsQueryable()` returns added in `2c23ba4` (S1168 fix) into a single `public static IQueryable<T> GetEmptyQueryable<T>()` helper on `LinqQueryBreakdown`. No behavior change — all 1180 tests stay green. Co-Authored-By: Thom Lamb <thomlamb@gmail.com>	2026-05-27 14:33:48 -05:00
Thom LambandClaude Opus 4.7	5202d93e8e	chore(sonar)!: mark public Markdown generator methods static (CA1822) ... Three public methods on the SqlServer-namespaced Markdown generators no longer touch instance state and now carry the `static` keyword: - `Markdown.SqlServer.QueryBreakdownGenerator.GenerateMermaidDiagram(QueryBreakdown, string?)` - `Markdown.SqlServer.SqlStatementGenerator.GenerateSequenceDiagram(ISqlBreakdown, string?)` - `Markdown.SqlServer.SqlStatementGenerator.GenerateEntityRelationshipDiagram(IEnumerable<string>, string?)` Plus one private bonus the analyzer caught on the same pass: - `LinqExpressionVisitor.ExtractSelectExpression` → static (non-breaking). Internal callers in the Snowflake/LinqToSql/PostgreSql wrapper classes and in the test fixtures are updated to the type-name form (`SqlServer.SqlStatementGenerator.GenerateSequenceDiagram(...)`). The wrappers retain their `_baseGenerator` field for now even though it is no longer used — that S4487 / unused-field cleanup is its own commit. BREAKING CHANGE: External NuGet consumers calling `generatorInstance.GenerateMermaidDiagram(...)`, `generatorInstance.GenerateSequenceDiagram(...)`, or `generatorInstance.GenerateEntityRelationshipDiagram(...)` on the SqlServer-namespaced generators must switch to type-name form, e.g. `Markdown.SqlServer.SqlStatementGenerator.GenerateSequenceDiagram(...)`. Calls through the Snowflake / LinqToSql / PostgreSql wrapper classes are unaffected at the call site. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-27 14:22:27 -05:00
Thom LambandClaude Opus 4.7	3c602a4625	chore(sonar): mark private helpers static (CA1822) ... Two private methods that don't touch instance state get the `static` keyword: - `LinqExpressionVisitor.ExtractMemberName` - `Markdown.Expressions.ExpressionGenerator.GenerateMermaidDiagram(Expression)` Both have only intra-class callers, so this is a non-breaking change — the call sites continue to work unchanged under C# method-resolution. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-27 14:19:26 -05:00
Thom LambandClaude Opus 4.7	2c23ba4a88	chore(sonar)!: return empty IQueryable instead of null from GetQuery<T> (S1168) ... Replaces `null` returns from `SqlBreakdownBase.GetQuery<T>()` and its four overrides (LinqQueryBreakdown, SqlServer/PostgreSql/Snowflake QueryBreakdown) with `Enumerable.Empty<T>().AsQueryable()`, and tightens the signature from `IQueryable<T>?` to `IQueryable<T>`. The "we can't reconstruct" semantic now lives in "the query yields zero rows" rather than a nullable return, which is what callers in LINQ pipelines actually want. Three LinqQueryBreakdownTests tests asserting `Is.Null` are renamed and updated to assert `Is.Empty`. BREAKING CHANGE: SqlBreakdownBase.GetQuery<T> and the SqlServer / PostgreSql / Snowflake / LinqToSql QueryBreakdown.GetQuery<T> overrides no longer return `IQueryable<T>?`; they now return a non-nullable `IQueryable<T>` that is empty when reconstruction isn't possible. External NuGet consumers null- checking the result must switch to `.Any()` / `Is.Empty` checks instead. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-27 14:18:31 -05:00