chore(sonar): clean up test-file INFO code smells (NUnit2045/2046/2011, CA1866/1861/1869) #14

Merged

bermudalamb merged 5 commits from fix/sonarqube-test-cases-code-smells into main 2026-05-27 13:02:43 -05:00

Conversation 0 Commits 5 Files Changed 51

+2280 -1246

5 Commits

Author	SHA1	Message	Date
Thom LambandClaude Opus 4.7	4fe9eb36e6	chore(sonar): second sweep — catch .Length, Is.Not.Empty, and newly-exposed Multiple groups (NUnit2046, NUnit2045) ... Re-runs `dotnet format analyzers --diagnostics NUnit2046 NUnit2045` after the Tier 2 Assert.Multiple wrap, which exposed: - `Has.Length.EqualTo(n)` rewrites for `string[]`/array `.Length` checks (the first pass only knew about `.Count`). - `Is.Not.Empty` rewrites for `Count, Is.GreaterThan(0)`. - A handful of new NUnit2045 groups that became wrappable once the initial Multiple blocks settled the surrounding indentation. Tests still 1180/1180 passing. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-27 12:14:13 -05:00
Thom LambandClaude Opus 4.7	470cb009b9	chore(sonar): cache JsonSerializerOptions in test fixture (CA1869) ... Promote the `new JsonSerializerOptions { Converters = { ... } }` instance that `OneTimeSetup` was constructing on each fixture run to a `private static readonly JsonSerializerOptions _jsonOptions` field, so the converter list isn't rebuilt per fixture. Strictly cosmetic here (OneTimeSetup runs once) but it's the change the analyzer wants and the field is the more idiomatic JsonSerializer pattern. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-27 12:02:25 -05:00
Thom LambandClaude Opus 4.7	77eb5d8b45	chore(sonar): hoist constant arrays to static readonly fields in tests (CA1861) ... Two inline `new[] { ... }` literals inside TestCaseSource yield-returns get hoisted to `static readonly string[]` fields with descriptive names (`monthListValues`, `calendarRange`) matching the surrounding test-case identifiers. Avoids reconstructing the same array on each call. Only the test-file CA1861 sites are touched; the three production-code sites flagged for the same rule are out of scope for this branch and will land separately. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-27 12:01:34 -05:00
Thom LambandClaude Opus 4.7	67512d23e1	chore(sonar): wrap independent assertions in Assert.Multiple (NUnit2045) ... Driven by `dotnet format analyzers --diagnostics NUnit2045`. The fixer groups consecutive independent `Assert.That(...)` calls into `Assert.Multiple(() => { ... })`, so a failing assertion no longer short-circuits the block — every failure inside the group is reported, which gives much better diagnostics on multi-property tests. Audit confirmed no Assert.Throws / Assert.Fail / Assert.Catch / Assert.Pass / Assert.DoesNotThrow got pulled inside a Multiple block (those need to short-circuit). All 1180 tests pass. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-27 11:59:47 -05:00
Thom LambandClaude Opus 4.7	505ada5017	chore(sonar): adopt Has.Count, Is.Empty, Does.Contain, char overloads in tests (NUnit2046, NUnit2011, CA1866) ... - NUnit2046: `Assert.That(x.Count, Is.EqualTo(n))` → `Assert.That(x, Has.Count.EqualTo(n))` (or `Is.Empty` when n==0) - NUnit2011: `Assert.That(s.Contains(x))` → `Assert.That(s, Does.Contain(x))` for richer failure messages - CA1866: `.StartsWith("$"|"@"|":")` → `.StartsWith('$'|'@'|':')` char overload Driven by `dotnet format analyzers --diagnostics NUnit2046 NUnit2011 CA1866` for the cases the Roslyn fixer handles, plus a regex sweep for the remaining `Count == n` (n>0) cases which the fixer doesn't address. CA1866 had no associated code fix and was edited by hand (3 sites in 2 files). All tests green (1180 passing). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-27 11:58:00 -05:00