8 Commits

Include renames

Author	SHA1	Message	Date
Thom Lamb	012e693fe1	chore: refactor for sonarqube issues	2026-05-22 17:13:31 -05:00
Thom LambandClaude Opus 4.7	2fae7738e3	test(pgsql): wrap CommandVisitor asserts in Assert.Multiple ... Resolves SonarQube NUnit2045. The three independent parameter-index assertions now report together instead of short-circuiting on the first failure. The Is.Not.Null guard in the reflection helper stays outside the multiple block because it gates the subsequent Invoke. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-20 13:02:28 -05:00
Thom LambandClaude Opus 4.7	5cb32d2311	refactor(query): extract shared Strata.SqlTools.Query model project ... Moves the byte-identical 19-file ExpressionFactory/Query tree (duplicated across Snowflake and SqlServer) into the new Strata.SqlTools.Query project under the flat namespace Strata.SqlTools.Query. Both dialect projects now reference the shared project; the Snowflake copies are deleted. Also folds in the IDE0028 fix on CalculationFilterGroup.GetValidFilters (collection expression []), which resolves both new-code IDE0028 smells in one place now that there is a single copy. Eliminates the 63 new duplicate lines flagged on the PR and removes the largest contributor to the project's 11.1% duplication density. No behavioral change: the moved types are identical to the originals. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-20 12:04:01 -05:00
Thom LambandClaude Opus 4.7	f96161a664	test(pgsql): align CommandVisitorTests namespace and drop dead fallback ... Code review follow-up on acfe29e: - Switch namespace to Strata.SqlTools.SqlBreakdown.Tests.PostgreSql to match the dominant convention in the sibling test folder. - Remove the unreachable SqlServer.CommandVisitor fallback in the reflection helper. The Assert.That guard alone is enough to surface a future regression. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-19 16:39:31 -05:00
Thom LambandClaude Opus 4.7	acfe29ee98	fix(pgsql): make CommandVisitor parameter index instance-scoped ... Resolves SonarQube S2696 in CommandVisitor.cs. The static _parameterIndex field was mutated from an instance method, causing every new CommandVisitor to inherit the previous instance's counter and never reset. Parameter indices now restart at $1 per visitor, which is the intended PostgreSQL behavior. Adds CommandVisitorTests.TwoVisitors_HaveIndependentParameterIndices to lock in the contract via reflection (FormatParameterName is protected). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-19 16:21:17 -05:00
Thom Lamb	8b0368e810	test: fix SqlBreakdown tests project	2026-05-15 13:39:14 -05:00
bermudalamb	79879c62b4	Update tests/Strata.SqlTools.Rules.Tests/Strata.SqlTools.Rules.Tests.csproj	2026-05-15 13:26:23 -05:00
Thom Lamb	5e467bcc9c	chore: initial git load of code space	2026-05-12 08:52:33 -05:00