chore: refactor for sonarqube issues
SonarQube Analysis / sonarqube (pull_request) Successful in 6m3s
SonarQube Analysis / sonarqube (pull_request) Successful in 6m3s
This commit is contained in:
@@ -74,18 +74,18 @@ public class QueryMarkdownGenerationTests
|
||||
Assert.That(File.Exists(outputFile), Is.True,
|
||||
$"Markdown file was not created: {outputFile}");
|
||||
|
||||
TestContext.WriteLine($"Generated: {fileName}.md");
|
||||
TestContext.Out.WriteLine($"Generated: {fileName}.md");
|
||||
successCount++;
|
||||
}
|
||||
catch (FormatException ex)
|
||||
{
|
||||
// Skip files that can't be parsed (e.g., partial queries with only WITH clauses)
|
||||
TestContext.WriteLine($"Skipped: {fileName}.sql - {ex.Message}");
|
||||
TestContext.Out.WriteLine($"Skipped: {fileName}.sql - {ex.Message}");
|
||||
skippedCount++;
|
||||
}
|
||||
}
|
||||
|
||||
TestContext.WriteLine($"Generated {successCount} markdown files, skipped {skippedCount} files in {_markdownOutputPath}");
|
||||
TestContext.Out.WriteLine($"Generated {successCount} markdown files, skipped {skippedCount} files in {_markdownOutputPath}");
|
||||
Assert.That(successCount, Is.GreaterThan(0), "At least one markdown file should be generated");
|
||||
}
|
||||
|
||||
@@ -126,7 +126,7 @@ public class QueryMarkdownGenerationTests
|
||||
catch (FormatException)
|
||||
{
|
||||
// Skip files that can't be parsed
|
||||
TestContext.WriteLine($"Skipped: {fileName}.sql (could not parse)");
|
||||
TestContext.Out.WriteLine($"Skipped: {fileName}.sql (could not parse)");
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
@@ -1,6 +1,5 @@
|
||||
using Strata.SqlTools.SqlBreakdown.Enums.SQL;
|
||||
using Strata.SqlTools.SqlBreakdown.Exceptions;
|
||||
using Strata.SqlTools.SqlBreakdown.Exceptions;
|
||||
using StatementReader = Strata.SqlTools.Statements.PostgreSql.StatementReader;
|
||||
|
||||
namespace Strata.SqlTools.SqlBreakdown.Tests.PostgreSql;
|
||||
|
||||
@@ -34,7 +34,7 @@ public class GetClausesCachingTests
|
||||
|
||||
// Assert
|
||||
Assert.That(clauses2, Is.Not.SameAs(clauses1), "GetClauses should return a new instance after SelectClause changes");
|
||||
Assert.That(clauses2.SelectClause.Clause, Is.EqualTo("id, name, email"));
|
||||
Assert.That(clauses2.SelectClause?.Clause, Is.EqualTo("id, name, email"));
|
||||
}
|
||||
|
||||
[Test]
|
||||
@@ -50,7 +50,7 @@ public class GetClausesCachingTests
|
||||
|
||||
// Assert
|
||||
Assert.That(clauses2, Is.Not.SameAs(clauses1), "GetClauses should return a new instance after FromClause changes");
|
||||
Assert.That(clauses2.FromClause.Clause, Is.EqualTo("customers"));
|
||||
Assert.That(clauses2.FromClause?.Clause, Is.EqualTo("customers"));
|
||||
}
|
||||
|
||||
[Test]
|
||||
@@ -66,7 +66,7 @@ public class GetClausesCachingTests
|
||||
|
||||
// Assert
|
||||
Assert.That(clauses2, Is.Not.SameAs(clauses1), "GetClauses should return a new instance after WhereClause changes");
|
||||
Assert.That(clauses2.WhereClause.Clause, Is.EqualTo("active = 1 AND deleted = 0"));
|
||||
Assert.That(clauses2.WhereClause?.Clause, Is.EqualTo("active = 1 AND deleted = 0"));
|
||||
}
|
||||
|
||||
[Test]
|
||||
@@ -83,7 +83,7 @@ public class GetClausesCachingTests
|
||||
|
||||
// Assert
|
||||
Assert.That(clauses2, Is.Not.SameAs(clauses1), "GetClauses should return a new instance after GroupByClause changes");
|
||||
Assert.That(clauses2.GroupByClause.Clause, Is.EqualTo("status, type"));
|
||||
Assert.That(clauses2.GroupByClause?.Clause, Is.EqualTo("status, type"));
|
||||
}
|
||||
|
||||
[Test]
|
||||
@@ -100,7 +100,7 @@ public class GetClausesCachingTests
|
||||
|
||||
// Assert
|
||||
Assert.That(clauses2, Is.Not.SameAs(clauses1), "GetClauses should return a new instance after HavingClause changes");
|
||||
Assert.That(clauses2.HavingClause.Clause, Is.EqualTo("COUNT(*) > 100"));
|
||||
Assert.That(clauses2.HavingClause?.Clause, Is.EqualTo("COUNT(*) > 100"));
|
||||
}
|
||||
|
||||
[Test]
|
||||
@@ -117,7 +117,7 @@ public class GetClausesCachingTests
|
||||
|
||||
// Assert
|
||||
Assert.That(clauses2, Is.Not.SameAs(clauses1), "GetClauses should return a new instance after OrderByClause changes");
|
||||
Assert.That(clauses2.OrderByClause.Clause, Is.EqualTo("name DESC"));
|
||||
Assert.That(clauses2.OrderByClause?.Clause, Is.EqualTo("name DESC"));
|
||||
}
|
||||
|
||||
[Test]
|
||||
@@ -159,7 +159,7 @@ public class GetClausesCachingTests
|
||||
|
||||
// Assert
|
||||
Assert.That(clauses2, Is.Not.SameAs(clauses1), "GetClauses should return a new instance when clause object is replaced");
|
||||
Assert.That(clauses2.SelectClause.Clause, Is.EqualTo("id, name, email"));
|
||||
Assert.That(clauses2.SelectClause?.Clause, Is.EqualTo("id, name, email"));
|
||||
}
|
||||
|
||||
[Test]
|
||||
@@ -181,8 +181,8 @@ public class GetClausesCachingTests
|
||||
|
||||
// Assert
|
||||
Assert.That(clauses2, Is.Not.SameAs(clauses1), "GetClauses should return a new instance after ApplyClauses");
|
||||
Assert.That(clauses2.SelectClause.Clause, Is.EqualTo("id, name"));
|
||||
Assert.That(clauses2.FromClause.Clause, Is.EqualTo("customers"));
|
||||
Assert.That(clauses2.SelectClause?.Clause, Is.EqualTo("id, name"));
|
||||
Assert.That(clauses2.FromClause?.Clause, Is.EqualTo("customers"));
|
||||
}
|
||||
|
||||
[Test]
|
||||
@@ -197,10 +197,10 @@ public class GetClausesCachingTests
|
||||
|
||||
// Assert
|
||||
Assert.That(clauses, Is.Not.Null);
|
||||
Assert.That(clauses.SelectClause.Clause, Is.EqualTo("id, name"));
|
||||
Assert.That(clauses.FromClause.Clause, Is.EqualTo("users"));
|
||||
Assert.That(clauses.WhereClause.Clause, Is.EqualTo("active = 1"));
|
||||
Assert.That(clauses.OrderByClause.Clause, Is.EqualTo("name ASC"));
|
||||
Assert.That(clauses.SelectClause?.Clause, Is.EqualTo("id, name"));
|
||||
Assert.That(clauses.FromClause?.Clause, Is.EqualTo("users"));
|
||||
Assert.That(clauses.WhereClause?.Clause, Is.EqualTo("active = 1"));
|
||||
Assert.That(clauses.OrderByClause?.Clause, Is.EqualTo("name ASC"));
|
||||
}
|
||||
|
||||
[Test]
|
||||
|
||||
Reference in New Issue
Block a user