6 Commits

Include renames

Author	SHA1	Message	Date
Thom LambandClaude Opus 4.7	c38d122d76	docs(skill): rewrite sonarqube cleanup section around tiered bulk fixes ... Section A (server inspection / API access) is unchanged. Section B is rewritten around the tiered model: - Tier 1 — mechanical: bulk fix multiple rule IDs in one dotnet format invocation (IDE0028, CA1825, CA1834, etc). - Tier 2 — judgment: one commit per rule, audit diff before staging. Calls out CA1822 public-static = binary break, CA1861 cryptic generated field names + duplicate-field collisions, CA1859 has no batch fixer. - Tier 3 — manual / no fixer: csharpsquid:Sxxxx, public-API design calls. Reference [[sonarqube-wontfix-rules]] memory for triage. Adds the local-Java-version gotcha: `./scan-sonar.ps1` is blocked here (system JRE is 8, scanner needs 17); CI handles the upload via actions/setup-java@v4 with temurin 17. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-26 15:50:25 -05:00
Thom LambandClaude Opus 4.7	d92996bd2e	docs(skill): add sonarqube cleanup + inspection skill ... Codifies (A) how to query the bermudalamb SonarQube 9.9 server's web API from PowerShell — Basic auth with token-as-username, the SONARQUBE_URL trailing-slash gotcha, the useful endpoints for triage and Won't Fix transitions; and (B) the per-rule-group cleanup loop (query → pick → edit → build → test → commit → scan → verify). References memory sonarqube-wontfix-rules rather than duplicating the catalog. Frontmatter follows superpowers:writing-skills (description is triggering conditions only, no workflow summary). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-26 09:34:44 -05:00
Thom LambandClaude Opus 4.7	1124e91141	chore(sonar): remove three unused local variables (S1481) ... - LinqQueryBreakdown.cs:211 - drop unused `expr` pattern binding (type test remains) - LinqQueryBreakdown.cs:279 - drop unused `firstEntity` (empty check already above) - LinqExpressionVisitor.cs:315 - drop unused `param` pattern binding Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-26 09:25:34 -05:00
Thom Lamb	82af7b8de1	fix(query): modernize CalculationFilterGroup and adjust IsValid behavior ... Refactors the `CalculationFilterGroup` class to utilize C# primary constructors and property initializers, improving conciseness and readability. The `IsValid()` method's logic is updated. Previously, it returned true if *any* filter in the group was valid. Now, it returns true only if *all* filters are valid, and an empty filter group is considered valid. This adjustment clarifies the group's validity criteria, aligning with common interpretations for `All` operations and addressing related technical debt.	2026-05-20 15:31:41 -05:00
Thom LambandClaude Opus 4.7	5cb32d2311	refactor(query): extract shared Strata.SqlTools.Query model project ... Moves the byte-identical 19-file ExpressionFactory/Query tree (duplicated across Snowflake and SqlServer) into the new Strata.SqlTools.Query project under the flat namespace Strata.SqlTools.Query. Both dialect projects now reference the shared project; the Snowflake copies are deleted. Also folds in the IDE0028 fix on CalculationFilterGroup.GetValidFilters (collection expression []), which resolves both new-code IDE0028 smells in one place now that there is a single copy. Eliminates the 63 new duplicate lines flagged on the PR and removes the largest contributor to the project's 11.1% duplication density. No behavioral change: the moved types are identical to the originals. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-20 12:04:01 -05:00
Thom Lamb	30f451d80c	feat(sonar): Add SonarQube static analysis and code coverage setup ... Establishes tooling to systematically analyze and address technical debt. This includes: - `scan-sonar.ps1`: An orchestration script for local SonarQube scans with coverage. - `Directory.Build.props`: Integrates SonarAnalyzer.CSharp for static analysis during build. - `coverlet.runsettings`: Configures code coverage collection using Coverlet. - `.claude/settings.local.json`: Adds permissions for AI to query SonarQube and local dev status.	2026-05-19 17:17:41 -05:00