fix(query): modernize CalculationFilterGroup and adjust IsValid behavior
SonarQube Analysis / sonarqube (pull_request) Successful in 3m9s
SonarQube Analysis / sonarqube (pull_request) Successful in 3m9s
Refactors the `CalculationFilterGroup` class to utilize C# primary constructors and property initializers, improving conciseness and readability. The `IsValid()` method's logic is updated. Previously, it returned true if *any* filter in the group was valid. Now, it returns true only if *all* filters are valid, and an empty filter group is considered valid. This adjustment clarifies the group's validity criteria, aligning with common interpretations for `All` operations and addressing related technical debt.
This commit is contained in:
@@ -23,7 +23,9 @@
|
||||
"Bash(Get-ChildItem src/Strata.SqlTools.SqlServer/ExpressionFactory/Query/*.cs)",
|
||||
"Bash(Measure-Object)",
|
||||
"Bash(Select-Object -ExpandProperty Count)",
|
||||
"PowerShell(dotnet build *)"
|
||||
"PowerShell(dotnet build *)",
|
||||
"Bash(Get-ChildItem src/Strata.SqlTools.Query/*.cs)",
|
||||
"Bash(Select-String -Pattern '^namespace ')"
|
||||
]
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user