chore(sonar): remove pass-through override that just calls base (S1185)
Rules/Rule/Groups/With.GetExpressions only called base.GetExpressions(). The comment 'do some ordering here??' indicates the override is a TODO stub. Drop the override and preserve the intent as an inline TODO on the class. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 4.7
parent
06e826a13c
commit
c06ab2ea29
@@ -7,15 +7,8 @@ namespace Strata.SqlTools.Rules.Rule.Groups;
|
|||||||
/// </summary>
|
/// </summary>
|
||||||
public class With : Base
|
public class With : Base
|
||||||
{
|
{
|
||||||
/// <summary>
|
// TODO: revisit whether ordering should be applied here before delegating
|
||||||
/// Gets the expressions from all rules, potentially with ordering applied.
|
// to the base GetExpressions(); inherit base behavior for now.
|
||||||
/// </summary>
|
|
||||||
/// <returns>An enumerable of BoolExpr rule expressions.</returns>
|
|
||||||
protected override IEnumerable<BoolExpr> GetExpressions()
|
|
||||||
{
|
|
||||||
// do some ordering here??
|
|
||||||
return base.GetExpressions();
|
|
||||||
}
|
|
||||||
|
|
||||||
/// <summary>
|
/// <summary>
|
||||||
/// Merges two BoolExpr expressions using WITH semantics.
|
/// Merges two BoolExpr expressions using WITH semantics.
|
||||||
|
|||||||
Reference in New Issue
Block a user