From c06ab2ea2929e9d5708329a45aa90e141f7605e9 Mon Sep 17 00:00:00 2001
From: Thom Lamb <tlamb@crateandbarrel.com>
Date: Tue, 26 May 2026 09:27:53 -0500
Subject: [PATCH] chore(sonar): remove pass-through override that just calls
 base (S1185)

Rules/Rule/Groups/With.GetExpressions only called base.GetExpressions(). The
comment 'do some ordering here??' indicates the override is a TODO stub.
Drop the override and preserve the intent as an inline TODO on the class.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
---
 src/Strata.SqlTools.Rules/Rule/Groups/With.cs | 11 ++---------
 1 file changed, 2 insertions(+), 9 deletions(-)

diff --git a/src/Strata.SqlTools.Rules/Rule/Groups/With.cs b/src/Strata.SqlTools.Rules/Rule/Groups/With.cs
index 56fa42c..a7899b3 100644
--- a/src/Strata.SqlTools.Rules/Rule/Groups/With.cs
+++ b/src/Strata.SqlTools.Rules/Rule/Groups/With.cs
@@ -7,15 +7,8 @@ namespace Strata.SqlTools.Rules.Rule.Groups;
 /// </summary>
 public class With : Base
 {
-    /// <summary>
-    /// Gets the expressions from all rules, potentially with ordering applied.
-    /// </summary>
-    /// <returns>An enumerable of BoolExpr rule expressions.</returns>
-    protected override IEnumerable<BoolExpr> GetExpressions()
-    {
-        // do some ordering here??
-        return base.GetExpressions();
-    }
+    // TODO: revisit whether ordering should be applied here before delegating
+    // to the base GetExpressions(); inherit base behavior for now.
 
     /// <summary>
     /// Merges two BoolExpr expressions using WITH semantics.