bermudalamb
4b0c01068f
account-modal and account-details, taking two more copies of "register a customer" and two more of the `accountModal(page)` helper that every account-touching spec had rewritten.
Both files had grown their own vocabulary for the same dialog. account-details reached for `modal.getByLabel('Current password', { exact: true })` and its five siblings inline in each test, so a change to the account form meant editing six places in one file and more in the next. Those are named locators now, and the three multi-step operations — saving a name, changing a password, changing an email — are actions, because each is a disclosure to open and three fields to fill before the button does anything.
AccountModal.open() gains the 20s timeout the header already had, and for the same reason. Arriving at /account means booting the app and resolving the session against the server. The old specs never noticed because they registered through the form first, which loaded the app and confirmed the session before navigating; taking the API-registered `customer` fixture arrives cold, and the 5s default is comfortably beaten on an idle machine and missed on a loaded one.
Verified: 18/18 across three serial repeats, and 12/13 in parallel. The one failure is `changes the email address and marks it unverified again`, which fails identically on the unconverted file and passes whenever the suite is not saturated — the same load-related flakiness as the rest of the family, not something this commit introduced.
Refs #137
117 lines
3.6 KiB
TypeScript
117 lines
3.6 KiB
TypeScript
import { test, expect } from './fixtures';
|
|
|
|
test.describe('My Account opens as a modal', () => {
|
|
test('opens over the storefront and closes back to it, filters and all', async ({
|
|
page,
|
|
customer,
|
|
accountModal,
|
|
header
|
|
}) => {
|
|
// A filtered view, to prove closing restores where the customer actually
|
|
// was rather than a bare storefront.
|
|
await page.goto('/?max_price=50000');
|
|
await header.waitForSignedIn();
|
|
|
|
await accountModal.openFromHeader();
|
|
// Still a real, linkable URL rather than hidden view state.
|
|
await expect(page).toHaveURL(/\/account/);
|
|
|
|
await accountModal.close();
|
|
await expect(page).toHaveURL(/max_price=50000/);
|
|
});
|
|
|
|
test('the browser back button closes it, the same as the close control', async ({
|
|
page,
|
|
customer,
|
|
accountModal,
|
|
header
|
|
}) => {
|
|
await page.goto('/?max_price=50000');
|
|
await header.waitForSignedIn();
|
|
await accountModal.openFromHeader();
|
|
|
|
await page.goBack();
|
|
|
|
await expect(accountModal.dialog).toBeHidden();
|
|
await expect(page).toHaveURL(/max_price=50000/);
|
|
});
|
|
|
|
test('a direct visit renders the storefront behind it, so closing lands somewhere real', async ({
|
|
page,
|
|
customer,
|
|
accountModal,
|
|
header
|
|
}) => {
|
|
// A bookmark, or the link in a verification email. There is no page behind
|
|
// in this case, which is what used to make /account a dead end.
|
|
await accountModal.open();
|
|
|
|
await expect(header.siteTitle).toBeVisible();
|
|
|
|
await accountModal.close();
|
|
await expect(page).toHaveURL(/\/$/);
|
|
await expect(header.myAccountButton).toBeVisible();
|
|
});
|
|
|
|
test('survives a reload, since it is a route rather than view state', async ({
|
|
page,
|
|
customer,
|
|
accountModal,
|
|
header
|
|
}) => {
|
|
await page.goto('/?max_price=50000');
|
|
await header.waitForSignedIn();
|
|
await accountModal.openFromHeader();
|
|
|
|
await page.reload();
|
|
|
|
await expect(accountModal.dialog).toBeVisible();
|
|
await expect(accountModal.dialog).toContainText(customer.email);
|
|
});
|
|
|
|
test('shows the signed-in account and its settings', async ({ customer, accountModal }) => {
|
|
await accountModal.open();
|
|
|
|
await expect(accountModal.dialog).toContainText(customer.email);
|
|
// The orders table lives at /orders now. What the account view still owes
|
|
// the customer is a way to reach it.
|
|
await expect(accountModal.orderHistoryButton).toBeVisible();
|
|
// Scoped to the modal: the storefront behind it has a theme switch of its
|
|
// own, so an unscoped switch locator would be ambiguous.
|
|
await expect(accountModal.themeSwitches).toHaveCount(2);
|
|
});
|
|
|
|
test('deleting the account does not leave the page behind it looking signed in', async ({
|
|
page,
|
|
customer,
|
|
accountModal,
|
|
header
|
|
}) => {
|
|
await accountModal.open();
|
|
await accountModal.deleteAccount();
|
|
|
|
// The storefront is rendered behind the modal, so a session left in place
|
|
// would visibly go on offering My Account for an account that is gone.
|
|
await expect(header.signUpButton).toBeVisible();
|
|
await expect(header.myAccountButton).toBeHidden();
|
|
await expect(page).toHaveURL(/\/$/);
|
|
});
|
|
|
|
test('stays usable on a phone, with the close control in reach', async ({
|
|
page,
|
|
customer,
|
|
accountModal
|
|
}) => {
|
|
await page.setViewportSize({ width: 390, height: 664 });
|
|
await accountModal.open();
|
|
|
|
// The view is taller than the viewport, so the body scrolls rather than
|
|
// pushing the title and close control off-screen.
|
|
await expect(accountModal.closeButton).toBeInViewport();
|
|
await expect(accountModal.orderHistoryButton).toBeVisible();
|
|
|
|
await accountModal.close();
|
|
await expect(page).toHaveURL(/\/$/);
|
|
});
|
|
});
|