bermudalamb
d4e2abe743
Adds favorites as another dimension of the existing storefront filter rather than a separate view, so it lives in the URL, shows up as a removable chip, and combines with category, tags, and price by AND like everything else. A customer can ask for "my favorites under $500 in Furniture" instead of only "my favorites". Sold favorites are included. The storefront shows sold items everywhere else, and a favorite that has just sold is often exactly what the customer came back to look at after being emailed about it in #34. Hiding them would make items disappear from a list the customer curated themselves. Anyone wanting only what they can still buy can combine the toggle with the status filter. Which customer "my favorites" means comes from the session, never from the query string, so a hand-edited URL cannot name someone else's favorites. A signed-out visitor sees the toggle and gets the same inline register/login prompt the heart button and Add to Cart already use; signing in resolves the gate and the filter applies on its own. A bookmarked favorites link whose session has expired says so rather than rendering an empty grid, which would tell the visitor they have no favorites instead of that we do not know who they are. The API answers 401 for the same reason, and the admin inventory refuses the filter outright rather than ignoring it. The shared SQL builder now requires callers to say whose favorites they mean, even when that is nobody, and throws instead of dropping the clause — a future caller that forgets the guard fails loudly rather than quietly returning the whole catalogue. Verified with 59 unit tests, 134 backend integration tests, and 70 end-to-end tests, all passing, with type checking clean on both sides.
44 lines
1.8 KiB
TypeScript
Executable File
44 lines
1.8 KiB
TypeScript
Executable File
import { Router, Request, Response } from 'express';
|
|
import { pool } from '../db';
|
|
import { asyncRoute } from '../asyncRoute';
|
|
import { PUBLIC_ITEM_SELECT } from '../itemSelect';
|
|
import { parseItemFilters, buildItemFilterSql, FilterError } from '../itemFilters';
|
|
|
|
const router = Router();
|
|
|
|
router.get('/', asyncRoute(async (req: Request, res: Response) => {
|
|
let filters;
|
|
try {
|
|
filters = parseItemFilters(req.query as Record<string, unknown>);
|
|
} catch (err) {
|
|
// A malformed filter is returned as an error rather than ignored, so a
|
|
// broken link shows itself instead of quietly listing the whole catalogue.
|
|
if (err instanceof FilterError) {
|
|
return res.status(400).json({ error: err.message });
|
|
}
|
|
throw err;
|
|
}
|
|
|
|
// 401 rather than an empty list: a signed-out visitor asking for "my
|
|
// favorites" has no favorites to be empty of, and answering with [] would
|
|
// render as "no items match these filters" — a plausible-looking lie. The
|
|
// storefront prompts for sign-in instead of sending this, so reaching here
|
|
// means a bookmarked link outlived its session.
|
|
if (filters.favoritesOnly && !req.customerId) {
|
|
return res.status(401).json({ error: 'sign in to filter by favorites' });
|
|
}
|
|
|
|
const { clauses, params } = buildItemFilterSql(filters, 1, req.customerId ?? null);
|
|
const where = clauses.length ? `WHERE ${clauses.join(' AND ')}` : '';
|
|
const { rows } = await pool.query(`${PUBLIC_ITEM_SELECT} ${where} ORDER BY i.created_at DESC`, params);
|
|
res.json(rows);
|
|
}));
|
|
|
|
router.get('/:id', asyncRoute(async (req: Request, res: Response) => {
|
|
const { rows } = await pool.query(`${PUBLIC_ITEM_SELECT} WHERE i.id = $1`, [req.params.id]);
|
|
if (!rows.length) return res.status(404).json({ error: 'not found' });
|
|
res.json(rows[0]);
|
|
}));
|
|
|
|
export default router;
|