synAdminandClaude Opus 5
ac3f6e91f5
Loads Brevo's web tracker for a signed-in customer who has consented, reports route changes as page views, and tracks the three events the issue asked for: added_to_cart, favorited, and checkout_completed. The four design questions were settled on the issue in August and this implements those answers. The consent gate is the part worth reading. The decision recorded on the issue was "gate it behind consent", but the sentence customers actually agreed to named only email: "I want to receive occasional emails about new one-of-a-kind items". Gating a tracker on `marketing_consent` while that was the stored wording would have treated "email me about new items" as authorisation to send someone's browsing to a third party, which it does not say — and this project stores the wording verbatim against each customer precisely so that a record says what the customer saw. So the sentence is widened here, and the tracker is gated on `analytics_consent`, a field the server computes by comparing the wording stored against a customer with the current constant. Changing the sentence therefore does not retroactively widen anybody's consent: everyone who agreed to the old text keeps their email consent and is not tracked until they re-consent through the account page. A boolean alone could not tell those two populations apart, which is the whole reason the text is stored per customer. `analyticsConsent` is exported and has its own unit test, because "agreeing to the old wording does not authorise tracking" is the rule that silently tracks people if it regresses — their flag really is true. QA stays out of the live Brevo account by construction rather than by remembering. The key is per-environment, the tracker never loads without one, and `docker-compose.qa.yml` sets an empty literal with no stack variable behind it, so nothing can inherit a value from the host or be pasted in from production's stack. Same reasoning as QA_DB_PASSWORD and the QA_SMTP_ names beside it. Events are reported from the API layer rather than the UI call sites, so no caller can add to the cart or favorite an item without it being counted, and each fires only after the response was accepted — a refused add is not reported as one. The two checkout completions each name their processor, because a demo purchase charges nothing and counting it as a sale would overstate revenue. The privacy policy gains an analytics section in this change rather than a follow-up, since the published policy previously described none of this and would otherwise have lagged the code. It is deliberate about the limits: withdrawing consent stops further reporting, but anything already sent stays with Brevo, and a script already injected cannot be un-injected — `stopBrevoTracking` stops calls, it does not unload sa.js. That is said in the code too, because "tracking stops" reads as a stronger promise than any web tracker can make. Verified: backend tsc clean, both lint suites 0 errors with no new warnings, 474 unit tests passing across 33 suites, and the frontend production build green including the compose-environment guard. Not verified: integration and e2e, which need a database and a Node this machine does not have active, and no real Brevo key was exercised — the tracker has never been observed reporting to an actual account. Closes #56 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
57 lines
1.9 KiB
TypeScript
57 lines
1.9 KiB
TypeScript
import { Customer } from './customerApi';
|
|
// See the note in cart/cartApi.ts: reported here rather than at the call sites
|
|
// so no caller can favorite an item without it being counted (#56).
|
|
import { brevoTrack } from '../brevo';
|
|
|
|
export interface Favorite {
|
|
item_id: number;
|
|
name: string;
|
|
status: 'available' | 'reserved' | 'sold';
|
|
created_at: string;
|
|
}
|
|
|
|
async function expectOk(res: Response, action: string): Promise<Response> {
|
|
if (res.ok) return res;
|
|
const detail = await res.json().catch(() => ({}));
|
|
throw new Error(detail.error || action);
|
|
}
|
|
|
|
export async function fetchFavorites(): Promise<Favorite[]> {
|
|
const res = await fetch('/api/customers/me/favorites');
|
|
// A signed-out visitor legitimately has none; anything else is a real error.
|
|
if (res.status === 401) return [];
|
|
await expectOk(res, 'failed to load favorites');
|
|
return res.json();
|
|
}
|
|
|
|
export async function addFavorite(itemId: number): Promise<void> {
|
|
await expectOk(
|
|
await fetch(`/api/customers/me/favorites/${itemId}`, { method: 'POST' }),
|
|
'failed to save favorite'
|
|
);
|
|
// After expectOk, which throws on failure, so a favorite that was not saved
|
|
// is not reported as one. Only favoriting is tracked, not un-favoriting:
|
|
// #56 asked for the act of favoriting as a signal of interest, and removal is
|
|
// a different question nobody has asked yet.
|
|
brevoTrack('favorited', { itemId });
|
|
}
|
|
|
|
export async function removeFavorite(itemId: number): Promise<void> {
|
|
await expectOk(
|
|
await fetch(`/api/customers/me/favorites/${itemId}`, { method: 'DELETE' }),
|
|
'failed to remove favorite'
|
|
);
|
|
}
|
|
|
|
export async function setFavoriteAlerts(enabled: boolean): Promise<Customer> {
|
|
const res = await expectOk(
|
|
await fetch('/api/customers/me/favorite-alerts', {
|
|
method: 'PUT',
|
|
headers: { 'Content-Type': 'application/json' },
|
|
body: JSON.stringify({ enabled })
|
|
}),
|
|
'failed to update notification preference'
|
|
);
|
|
return res.json();
|
|
}
|