bermudalambandClaude Opus 5
e7fd63c2e6
Infrastructure only. No route is converted, nothing changes at run time. The mirror had already drifted, which settles how it should be maintained. schema.ts was missing item_drafts and upload_links from the moment #222 landed, because the spike pulled into ./drizzle and copied the file into src/ by hand, and nobody had reason to look at the copy for a week. So `out` now points at src/db-drizzle and pull refreshes in place — the copy step that made the drift possible is gone — and tablesFilter excludes pgmigrations, which is node-pg-migrate's bookkeeping and has no business in a model of the application's schema. A stale mirror is worse than no mirror, because Drizzle infers row types from it: a converted query would type-check against a schema the database does not have and fail at run time on a column that does not exist. drizzleSchema.integration.test.ts fails when the two disagree, on tables and on columns. It was checked by removing item_drafts from the mirror and confirming the test fails naming it, rather than trusting a green run on a file that already matched. pull also emits 0000_*.sql and meta/ into `out`, because that directory serves both purposes. Both are gitignored: this project's migration history is backend/migrations, hand-written and mostly prose, and #219 has not chosen otherwise — a stray SQL file in src/ is at best noise and at worst mistaken for real history. db is exported beside pool and shares its connections. Both must work at once, since conversion is file by file across 187 sites; separate pools would make a transaction on one invisible to the other and silently double the configured limits. The generated files are excluded from linting. #261 hand-fixed an unused-parameter warning in schema.ts and this re-pull put it straight back, which is the argument in one line: linting generated code buys a fix the next regeneration undoes. itemFilters.drizzle.ts, which is hand-written, is still linted. CONVENTIONS.md records the sql.param() array trap before anyone hits it — the wrong form type-checks, reads correctly and fails at run time as invalid Postgres — and the reason the adoption is worth doing at all, which is that ${value} emits a bind parameter and there is no way to spell "interpolate this as SQL" by accident. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
76 lines
2.8 KiB
JavaScript
76 lines
2.8 KiB
JavaScript
import js from '@eslint/js';
|
|
import tseslint from 'typescript-eslint';
|
|
import sonarjs from 'eslint-plugin-sonarjs';
|
|
import globals from 'globals';
|
|
|
|
// Named `.mjs` because this package is CommonJS — `eslint.config.js` would be
|
|
// parsed as CJS and the imports above would fail.
|
|
//
|
|
// Policy: every preset is downgraded to advisory, and the rules that actually
|
|
// fail the build are listed once at the bottom. That way the CI gate is
|
|
// readable in one place rather than inferred from four presets' defaults.
|
|
// The reasoning behind the split, and the measurements it rests on, are in
|
|
// docs/superpowers/specs/2026-08-19-eslint-design.md.
|
|
|
|
/**
|
|
* Rewrites a preset's enabled rules to `warn`, preserving each rule's options.
|
|
* Rules the preset explicitly turned off stay off — a preset that disables a
|
|
* rule means it, and flipping those to `warn` turns the whole of SonarJS's
|
|
* opt-in catalogue (file headers, naming conventions) into daily noise.
|
|
*/
|
|
const advisory = (config) => ({
|
|
...config,
|
|
rules: Object.fromEntries(
|
|
Object.entries(config.rules ?? {}).map(([rule, level]) => {
|
|
const severity = Array.isArray(level) ? level[0] : level;
|
|
if (severity === 'off' || severity === 0) return [rule, level];
|
|
return [rule, Array.isArray(level) ? ['warn', ...level.slice(1)] : 'warn'];
|
|
})
|
|
),
|
|
});
|
|
|
|
export default tseslint.config(
|
|
// src/db-drizzle/schema.ts and relations.ts are `drizzle-kit pull` output, not
|
|
// written by anyone here. #261 hand-fixed an unused-parameter warning in the
|
|
// schema and #217's re-pull put it straight back, which is the whole argument:
|
|
// linting generated code buys a fix that the next regeneration undoes. The
|
|
// hand-written files in that directory are still linted.
|
|
{
|
|
ignores: [
|
|
'dist/**',
|
|
'coverage/**',
|
|
'eslint.config.mjs',
|
|
'src/db-drizzle/schema.ts',
|
|
'src/db-drizzle/relations.ts'
|
|
]
|
|
},
|
|
|
|
...[js.configs.recommended, ...tseslint.configs.recommended, sonarjs.configs.recommended].map(
|
|
advisory
|
|
),
|
|
|
|
{
|
|
// `tests/` is deliberately out of scope for now: tsconfig.json only includes
|
|
// `src`, so type-aware linting has no program for the test files, and
|
|
// widening it is a separate change with its own violation count.
|
|
files: ['src/**/*.ts'],
|
|
languageOptions: {
|
|
globals: globals.node,
|
|
parserOptions: {
|
|
projectService: true,
|
|
tsconfigRootDir: import.meta.dirname,
|
|
},
|
|
},
|
|
rules: {
|
|
// The two rules this repo has actually been bitten by. #59 is the whole
|
|
// argument: an async handler whose rejection nothing forwards produces no
|
|
// response at all, and the request hangs rather than failing visibly.
|
|
'@typescript-eslint/no-floating-promises': 'error',
|
|
'@typescript-eslint/no-misused-promises': [
|
|
'error',
|
|
{ checksVoidReturn: { attributes: false } },
|
|
],
|
|
},
|
|
}
|
|
);
|