bermudalambandClaude Opus 5
f156cecd87
Three mount points, so a render error costs the smallest part of the page it can. The catalogue boundary is the one that earns its keep. The likeliest throw in this app is a component rendering data from the API, and the item grid renders the most of it per page — contained there, the header, cart badge, filters and footer all survive, so a customer can still navigate instead of being handed one dead page. The modal boundary exists because the modal-route arrangement couples two independent trees. /account, /login and the rest render as modals over the storefront as a backdrop, so without a boundary between them a throw in Account blanks the storefront behind it and a throw in the storefront takes the open modal with it. One boundary separates them in both directions. Every escape action is a hard navigation rather than a Link. This is worth stating because the obvious implementation is wrong: a boundary does not reset when the route changes, so a Link would change the URL and go on rendering the fallback, which reads as the app being permanently broken. ErrorFallback changed too, outside this change's original scope and for a reason worth recording. antd's Result renders its title as a plain div with no heading semantics, so a page whose entire content is an error message offered a screen-reader user navigating by headings nothing at all to find. The title is now wrapped in Typography.Title. The tests assert a heading role and were right to; the component was what needed fixing, not the assertion. DevThrow throws on ?boom=<scope> and is mounted only behind import.meta.env.DEV, so Rollup drops it from a production build. Checked in both directions rather than trusted: the dev server serves it, and a production bundle greps to zero occurrences of its marker. A gate that is silently always-off looks identical to one that works. Verified: 87 end-to-end tests pass, 4 of them new — each boundary catches rather than blanking, the header survives a catalogue throw, the storefront survives a modal throw, and the report is observed reaching /api/client-errors on the wire rather than assumed. Build clean, lint 0 errors and 31 warnings. Refs #62 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
20 lines
888 B
TypeScript
20 lines
888 B
TypeScript
import { ErrorContext } from '../errorReporting';
|
|
|
|
// A deliberate throw, reachable only from the dev server. Every mount site
|
|
// guards it with `import.meta.env.DEV &&`, which Vite replaces with `false` in
|
|
// a production build so Rollup drops both the element and this module.
|
|
//
|
|
// The marker is in the thrown message so a production bundle can be grepped for
|
|
// it. A gate that is silently always-off looks identical to one that works, so
|
|
// this is checked rather than trusted — the same reasoning as #61's coverage
|
|
// instrumentation gate.
|
|
export const DEV_THROW_MARKER = '__DEV_THROW_BOUNDARY__';
|
|
|
|
export default function DevThrow({ scope }: Readonly<{ scope: ErrorContext }>) {
|
|
const requested = new URLSearchParams(window.location.search).get('boom');
|
|
if (requested === scope) {
|
|
throw new Error(`${DEV_THROW_MARKER} deliberate throw in ${scope}`);
|
|
}
|
|
return null;
|
|
}
|