From c350f0a588bee629aba6c57ed61204a02ff56efc Mon Sep 17 00:00:00 2001 From: Thom Lamb Date: Tue, 18 Aug 2026 08:20:43 -0500 Subject: [PATCH] ci: distinguish between missing secrets and variables in QA build Separate error messages and guidance for missing secrets versus variables in the QA build configuration check to improve clarity for developers. --- .gitea/workflows/qa-build.yml | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/.gitea/workflows/qa-build.yml b/.gitea/workflows/qa-build.yml index 59c126e..690fa1c 100644 --- a/.gitea/workflows/qa-build.yml +++ b/.gitea/workflows/qa-build.yml @@ -39,13 +39,20 @@ jobs: run: | missing="" [ -n "${{ secrets.REGISTRY_TOKEN }}" ] || missing="$missing REGISTRY_TOKEN" - [ -n "${{ vars.REGISTRY_USER }}" ] || missing="$missing REGISTRY_USER" [ -n "${{ secrets.BREVO_API_KEY }}" ] || missing="$missing BREVO_API_KEY" + missingVars="" + [ -n "${{ vars.REGISTRY_USER }}" ] || missing="$missing REGISTRY_USER" [ -n "${{ vars.QA_NOTIFY_TO }}" ] || missing="$missing QA_NOTIFY_TO" [ -n "${{ vars.QA_NOTIFY_FROM }}" ] || missing="$missing QA_NOTIFY_FROM" - if [ -n "$missing" ]; then - echo "::error::Missing configuration:$missing" - echo "Secrets go in Settings > Actions > Secrets; variables in Settings > Actions > Variables." + if [ -n "$missing" || -n "$missingVars" ]; then + if [ -n "$missing" ]; then + echo "::error::Missing configuration secrets:$missing" + echo "Secrets go in Settings > Actions > Secrets" + fi + if [ -n "$missingVars" ]; then + echo "::error::Missing configuration variables:$missingVars" + echo "Variables go in Settings > Actions > Variables." + fi exit 1 fi echo "All required secrets and variables are present." -- 2.54.0