fix(uploads): the image backfill script does not ship in the container image #231

New Issue

2026-08-29T14:56:03-05:00

bermudalamb commented

2026-08-29 14:56:03 -05:00

npm run backfill:images cannot run in QA or production. The script from #226 exists only in the repository, never in the image, so the half of that issue that closes the exposure on already-stored photos has no way to execute where the photos actually are.

Three separate reasons, each sufficient on its own:

backend/tsconfig.json declares "include": ["src"] and "rootDir": "src", so scripts/ is never compiled — there is no dist/scripts.
The Dockerfile copies dist, migrate.js and migrations. scripts/ never enters the image.
tsx, which the npm script invokes, is a devDependency and is stripped by npm install --omit=dev in the final stage.

Found while writing the QA verification checklist for #226, before it cost anyone a trip to the NAS. New uploads are unaffected and were verified working in QA — this is only the backfill.

Why it happened

scripts/bench-hash-latency.ts is the pattern that was followed, and it is a development tool that never needs to run in a deployed environment. This script has the opposite requirement: it is an operational task that can only be useful where the images are. migrate.js is the right precedent — it sits at a path the image copies, and the container invokes it directly.

Fix

Move it to src/backfillImageReencode.ts so it compiles into dist and ships. Both of its runtime dependencies, sharp and pg, are production dependencies already, so nothing else needs to change in the image.

Point the npm script at the compiled output rather than at tsx, so one command behaves identically on a laptop and inside the container:

"backfill:images": "node dist/backfillImageReencode.js"

Guard the entry point with require.main === module so that a file living in src/ cannot execute a catalogue-wide rewrite merely by being imported.

Verification

dist/backfillImageReencode.js exists after npm run build
It runs from a built image with --omit=dev installed, with no tsx present
Report mode and --apply still behave as they did, and a second --apply still skips

Blocks Task 5 of docs/superpowers/plans/2026-08-29-strip-exif-and-reencode.md. Follows #226.

`npm run backfill:images` cannot run in QA or production. The script from #226 exists only in the repository, never in the image, so the half of that issue that closes the exposure on **already-stored** photos has no way to execute where the photos actually are. Three separate reasons, each sufficient on its own: - `backend/tsconfig.json` declares `"include": ["src"]` and `"rootDir": "src"`, so `scripts/` is never compiled — there is no `dist/scripts`. - The Dockerfile copies `dist`, `migrate.js` and `migrations`. `scripts/` never enters the image. - `tsx`, which the npm script invokes, is a devDependency and is stripped by `npm install --omit=dev` in the final stage. Found while writing the QA verification checklist for #226, before it cost anyone a trip to the NAS. New uploads are unaffected and were verified working in QA — this is only the backfill. ## Why it happened `scripts/bench-hash-latency.ts` is the pattern that was followed, and it is a development tool that never needs to run in a deployed environment. This script has the opposite requirement: it is an operational task that can *only* be useful where the images are. `migrate.js` is the right precedent — it sits at a path the image copies, and the container invokes it directly. ## Fix Move it to `src/backfillImageReencode.ts` so it compiles into `dist` and ships. Both of its runtime dependencies, `sharp` and `pg`, are production dependencies already, so nothing else needs to change in the image. Point the npm script at the compiled output rather than at `tsx`, so one command behaves identically on a laptop and inside the container: ``` "backfill:images": "node dist/backfillImageReencode.js" ``` Guard the entry point with `require.main === module` so that a file living in `src/` cannot execute a catalogue-wide rewrite merely by being imported. ## Verification - `dist/backfillImageReencode.js` exists after `npm run build` - It runs from a built image with `--omit=dev` installed, with no `tsx` present - Report mode and `--apply` still behave as they did, and a second `--apply` still skips Blocks Task 5 of `docs/superpowers/plans/2026-08-29-strip-exif-and-reencode.md`. Follows #226.

bermudalamb referenced this issue from a commit

2026-08-29 15:04:02 -05:00

fix(uploads): ship the image backfill script in the container image (#231)

bermudalamb referenced a pull request that will close this issue

2026-08-29 15:04:18 -05:00

fix(uploads): ship the image backfill script in the container image (#231) #232

bermudalamb closed this issue

2026-08-29 15:10:07 -05:00

bermudalamb referenced this issue from a commit

2026-08-29 15:10:08 -05:00

Merge pull request 'fix(uploads): ship the image backfill script in the container image (#231)' (#232) from fix/231-ship-backfill-script into main

Sign in to join this conversation.