feat(ci): add ESLint to both workspaces with a defect-only CI gate (#60)

TypeScript's strict mode checks types and nothing else, so nothing enforced the React hook rules, the SonarJS rules, or unhandled-promise detection. Adds a flat config per workspace, a lint script in each, and a lint job in tests.yml.

The rule selection is the substance of this change and is measured rather than guessed. A full-strength config reports 435 violations across 50 files, but 325 of those are the no-unsafe-* family from recommendedTypeChecked, every one downstream of pool.query() returning any rows and untyped fetch responses. Typing those boundaries is the whole of #65, so enabling the rules here would ship a linter whose output is three-quarters another issue's backlog — the reliable way to teach everyone to ignore lint output. This enables recommended plus the two type-aware rules that catch defects rather than describe type debt, which leaves 110 findings.

Both configs downgrade every preset to a warning and then list the error rules explicitly at the bottom, so the CI gate is readable in one place instead of inferred from four presets' defaults. Errors are no-floating-promises, no-misused-promises, rules-of-hooks, exhaustive-deps and jsx-a11y/alt-text; everything else warns. No --max-warnings flag is needed because ESLint already exits non-zero on errors and zero on warnings. no-misused-promises runs with checksVoidReturn.attributes false, since onClick={async () => ...} is idiomatic React and safe when the handler catches its own errors — at the default it flags every antd button in the admin screens, 25 of its 28 hits, and a rule that is 89% noise gets switched off within a week.

The 37 errors this surfaced were mostly not the mechanical fix they looked like. The plan assumed the 30 floating promises were fire-and-forget loaders that already handled their own failures, which was true of the one sampled when writing the design and false for most of the rest: Admin, Categories, Customers, Tags, Settings, Account and CustomerAuthContext all had no rejection handling at all, so `void` on them would have hidden real failures rather than annotated deliberate ones. Each of those loaders now catches and surfaces the failure before the call site voids it. The CustomerAuthContext one was a live bug — a rejected fetchMe left loading true forever, rendering as a permanent spinner instead of a signed-out page.

Admin's load became a useCallback so its effect can name it honestly rather than suppress the dependency, Categories' drop handler was split so the function antd receives returns void as its type says, and Cart's effect now names refreshCartContext, which is a useCallback with an empty dependency list and so cannot re-run it. The only disable added is in asyncRoute, where returning a promise where Express expects void is the entire point of the wrapper and the promise cannot reject.

Two of the issue's premises did not survive measurement, both recorded in the spec: exhaustive-deps flags 2 cases rather than the 10 inferred from empty dependency arrays, and the backend was already clean on the defect rules because #59 wrapped every async route.

Verified: lint, build, 78 unit, 134 integration and 83 e2e all pass in both workspaces, and the CI gate was confirmed to fail by introducing a deliberate violation rather than by assuming the job is wired correctly.

Closes #60

frontend/src/admin/Admin.tsx

@@ -1,4 +1,4 @@
-import { useEffect, useRef, useState } from 'react';
+import { useCallback, useEffect, useRef, useState } from 'react';
 import {
   Layout, Table, Button, Form, Input, InputNumber, Upload, Modal,
   Space, Tag, Typography, Switch, message, Image as AntImage, theme, Tabs,
@@ -43,24 +43,32 @@ function Inventory() {
   // arrive out of order and an older one can repaint stale rows over a newer
   // result. Only the most recently issued request is allowed to set state.
   const latestRequest = useRef(0);
-  const load = (active: ItemFilters = filters) => {
+  // useCallback rather than a plain function so the effect below can depend on
+  // it honestly: a function rebuilt every render would either loop forever in
+  // the dependency array or have to be suppressed out of it.
+  const load = useCallback((active: ItemFilters = filters) => {
     const seq = ++latestRequest.current;
-    return fetchAdminItems(active).then(rows => {
-      if (seq === latestRequest.current) setItems(rows);
-    });
-  };
+    return fetchAdminItems(active)
+      .then(rows => {
+        if (seq === latestRequest.current) setItems(rows);
+      })
+      // Without this the table simply keeps showing whatever it had, so a
+      // failed refetch after a save looks identical to a save that did not
+      // change anything.
+      .catch(() => message.error('Could not load items'));
+  }, [filters]);
 
   // The item form needs the current category tree and tag list; both change
   // from the sibling tabs, so they're refetched whenever the modal opens.
-  const loadOptions = () => Promise.all([
+  const loadOptions = useCallback(() => Promise.all([
     fetchAdminCategories().then(setCategories),
     fetchAdminTags().then(setTags)
-  ]);
+  ]).catch(() => message.error('Could not load categories and tags')), []);
 
   // Refetch whenever the filters change — filtering is server-side so the
   // result stays correct regardless of how many items exist.
-  useEffect(() => { load(filters); }, [filters]);
-  useEffect(() => { loadOptions(); }, []);
+  useEffect(() => { void load(filters); }, [load, filters]);
+  useEffect(() => { void loadOptions(); }, [loadOptions]);
 
   function applyFilters(next: ItemFilters) { setFilters(next); }
   function clearFilters() { setFilters(EMPTY_FILTERS); }
@@ -70,7 +78,7 @@ function Inventory() {
     form.resetFields();
     setFileList([]);
     setDescription('');
-    loadOptions();
+    void loadOptions();
     setModalOpen(true);
   }
 
@@ -84,7 +92,7 @@ function Inventory() {
     });
     setFileList([]);
     setDescription(item.description || '');
-    loadOptions();
+    void loadOptions();
     setModalOpen(true);
   }
 
@@ -114,8 +122,8 @@ function Inventory() {
 
     message.success(editingItem ? 'Item updated' : 'Item added');
     setModalOpen(false);
-    load();
-    loadOptions();
+    void load();
+    void loadOptions();
   }
 
   // Status changes silently did nothing on failure — the row simply stayed put
@@ -127,7 +135,7 @@ function Inventory() {
       message.error(`Couldn't ${label} — ${(err as Error).message}`);
       return;
     }
-    load();
+    void load();
   }
 
   async function handleDelete(id: number) {
@@ -138,7 +146,7 @@ function Inventory() {
       return;
     }
     message.success('Item deleted');
-    load();
+    void load();
   }
 
   async function handleDeleteImage(itemId: number, imageId: number) {
@@ -149,7 +157,7 @@ function Inventory() {
       return;
     }
     message.success('Image removed');
-    load();
+    void load();
     setEditingItem(prev => prev && prev.id === itemId
       ? { ...prev, images: prev.images.filter(img => img.id !== imageId) }
       : prev);
@@ -162,7 +170,7 @@ function Inventory() {
       render: (images: Item['images']) =>
         images[0] ? (
           <span style={{ position: 'relative', display: 'inline-block' }}>
-            <img src={images[0].image_path} style={{ width: 60 }} />
+            <img src={images[0].image_path} alt="" style={{ width: 60 }} />
             {images.length > 1 && (
               <Tag style={{ position: 'absolute', bottom: -4, right: -8, fontSize: 10 }}>+{images.length - 1}</Tag>
             )}