fix(qa): build the QA image before deploying the stack (#25)
Deploying the stack first failed with "pull access denied for redefined-designs, repository does not exist or may require docker login". The README had the Portainer stack creation ahead of the build, so no local redefined-designs:qa image existed and Compose fell back to pulling from Docker Hub, where the repository does not exist. The build step now comes first in the one-time setup, and the review workflow says to rebuild before restarting the stack — the stack builds nothing itself and would otherwise run whatever was last tagged :qa. pull_policy: never makes the failure legible: a missing local image now reports itself as missing rather than as a registry authentication problem. Noted as safe to remove if the NAS's Compose ever rejects the key, since it only affects the error message. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -172,7 +172,17 @@ It differs from production deliberately: `DEMO_MODE=true` with no PayPal credent
|
||||
|
||||
### One-time setup on the NAS
|
||||
|
||||
Create the directory structure. These paths are deliberately **not** under `/volume1/configs/redefined-designs` — sharing production's Postgres directory would mean QA writing into production's database files.
|
||||
**Build the image before creating the stack.** `redefined-designs:qa` exists only on the NAS — it is never pushed to a registry. If the stack is deployed first, Compose finds no local image, falls back to pulling from Docker Hub, and fails with a misleading `pull access denied ... repository does not exist or may require 'docker login'`.
|
||||
|
||||
```bash
|
||||
cd /volume1/docker/redefined-designs
|
||||
sudo docker build --no-cache -t redefined-designs:qa /volume1/docker/redefined-designs
|
||||
sudo docker images | grep redefined-designs # confirm the qa tag is present
|
||||
```
|
||||
|
||||
For the same reason, leave Portainer's **"Pull latest image"** toggle **off** when deploying or redeploying this stack. The compose file sets `pull_policy: never` so a missing image reports itself as missing rather than as a registry authentication problem.
|
||||
|
||||
Next, create the directory structure. These paths are deliberately **not** under `/volume1/configs/redefined-designs` — sharing production's Postgres directory would mean QA writing into production's database files.
|
||||
|
||||
```bash
|
||||
sudo mkdir -p /volume1/configs/redefined-designs-qa/postgres
|
||||
@@ -204,6 +214,8 @@ gitc() { sudo docker run --rm -it -v /volume1/docker/redefined-designs:/repo -v
|
||||
gitc pull origin main
|
||||
gitc log --oneline -3
|
||||
|
||||
# Rebuild the QA image before restarting the stack — the stack does not build
|
||||
# anything itself, and will otherwise run whatever was last tagged :qa.
|
||||
sudo docker build --no-cache -t redefined-designs:qa /volume1/docker/redefined-designs
|
||||
# start the redefined-designs-qa stack in Portainer
|
||||
|
||||
|
||||
Reference in New Issue
Block a user