test(backend): fail the build when the compose file lacks a required variable (#107)

The one-line compose fix in the previous commit unblocks QA. This is the part that stops it happening again, and it is the more useful half.

The failure was not really a missing variable. It was that nothing connected two files: envValidation.ts gained a required variable, docker-compose.qa.yml did not set it, and nothing noticed until a container refused to boot on deploy. CI passed the whole time, because CI supplies its own environment and never reads the compose file — which is exactly why "CI is green" was the wrong evidence to have offered.

So a unit test now reads the compose file and asserts it sets everything the validator demands. It imports ALWAYS_REQUIRED rather than restating it, which is the only version of this test worth having: a copied list would pass forever while the next variable added to the validator went unguarded in precisely the same way.

Two further assertions earn their place. UPLOADS_DIR is hardcoded rather than taken from a stack variable on the grounds that it must agree with the volume mapping, so the test checks it against the mount rather than leaving that a claim in a comment. And ADMIN_GATE_SECRET must be present as an interpolation rather than a literal, since a secret in the repository would defeat the point of having one.

There is also a test guarding the test: a regex that matched nothing would make every other assertion in the file vacuously true, so one case asserts that parsing found entries at all.

Fired deliberately rather than assumed. Removing the UPLOADS_DIR line reproduces the original failure as two failing tests; restoring it returns to ten passing. A guard that has only ever been observed passing is not known to guard anything.

What this cannot do is check production, which runs from a Portainer stack outside this repository. That gap is now written into the README beside the validation rules, along with the reason a variable set only in Portainer's stack UI never reaches the container: stack variables are interpolated into the compose file, not handed to the service.

172 unit tests pass, lint unchanged at 4 warnings.

Refs #107
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

backend/src/envValidation.ts

@@ -27,7 +27,13 @@ export interface EnvValidation {
 }
 
 // Without these the process cannot do its job at all.
-const ALWAYS_REQUIRED = [
+//
+// Exported so tests/unit/composeEnvironment.test.ts can assert the deploying
+// environment actually sets them. #107 happened because this list grew and
+// docker-compose.qa.yml did not: the check has to read this list rather than a
+// copy of it, or the next variable added here goes unguarded in exactly the
+// same way.
+export const ALWAYS_REQUIRED = [
   'PGHOST',
   'PGPORT',
   'PGUSER',