bermudalamb/redefined-designs
1
0
Fork 0
Code Issues 2 Pull Requests 1 Actions Packages Projects 3 Releases Wiki Activity

test(e2e): convert the storefront and filter specs onto page objects (#137)
Linting / lint (pull_request) Successful in 2m2s
Details
SonarQube Analysis / sonarqube (pull_request) Successful in 17m17s
Details

Browse Source 
storefront, storefront-errors, theme, error-boundary and filters.

filters.spec.ts carried the last hand-rolled copies of createCategory, createTag and createItem, and the hardcoded `http://localhost:5173` that meant changing the port in the config would have moved every test except this one. Seeding now goes through support/api, and the host it needs lives in one constant. It has to be a constant rather than the config's baseURL: beforeAll runs with worker-scoped fixtures only and cannot read a test-scoped option, which is why the URL was inlined there in the first place.

New FilterDrawer object. The two rules it encodes are the ones the tests exist to pin down and neither is guessable from a locator: categories are a tree because the filter matches a node and everything filed beneath it, and tags combine with AND rather than OR, so selecting two means "must have both".

The active-filter chips go on StorefrontPage rather than the drawer, because that is where they render — and the scoping matters, since the drawer carries a "Clear all" of its own that an unscoped locator also matches.

StorefrontPage gains the three things the catalogue says instead of listing items. They are named together deliberately: the distinction between "No items yet" and "Couldn't load items" is the point, and several tests assert one is showing while the other is not, because telling a customer the shop is empty when the server is broken hides the outage.

The theme switch and the attribute it writes are both on Header now. The switch is in the header and `data-theme` lands on <body>, so a spec previously had to know about `body` to observe the control it had just clicked.

Verified: 12/12 across the four small specs, 8/8 on filters, tsc clean, lint unchanged at the 30-warning src baseline.

Refs #137
This commit is contained in:
bermudalamb
2026-08-23 17:50:59 -05:00
parent 4b0c01068f
commit 9b3a03d1bf
10 changed files with 256 additions and 157 deletions
Download Patch File Download Diff File Expand all files Collapse all files
frontend/tests/e2e/theme.spec.ts
+10 -12
View File
@@ -1,25 +1,23 @@
import { test, expect } from './fixtures';
test.describe('Theme switching', () => {
test('toggling the switch changes the body theme attribute', async ({ page }) => {
await page.goto('/');
const body = page.locator('body');
const initial = await body.getAttribute('data-theme');
test('toggling the switch changes the body theme attribute', async ({ storefront, header }) => {
await storefront.goto();
const initial = await header.currentTheme();
await page.getByRole('switch').click();
await header.themeToggle.click();
await expect(async () => {
const updated = await body.getAttribute('data-theme');
expect(updated).not.toBe(initial);
expect(await header.currentTheme()).not.toBe(initial);
}).toPass();
});
test('theme preference persists across a reload', async ({ page }) => {
await page.goto('/');
await page.getByRole('switch').click();
const chosen = await page.locator('body').getAttribute('data-theme');
test('theme preference persists across a reload', async ({ page, storefront, header }) => {
await storefront.goto();
await header.themeToggle.click();
const chosen = await header.currentTheme();
await page.reload();
await expect(page.locator('body')).toHaveAttribute('data-theme', chosen || '');
await expect(header.themedBody).toHaveAttribute('data-theme', chosen || '');
});
});