fix(privacy): separate analytics consent from email consent (#56)

The previous commit widened the marketing consent sentence to cover the Brevo tracker, so one checkbox carried both purposes. That is the specific pattern GDPR rejects: consent has to be granular, and current EDPB guidance treats bundling tracking consent with subscription consent as invalid because the customer cannot accept one purpose and refuse the other. Quebec's Law 25 s.8.1 is stricter again — profiling technology has to be off until the person switches it on, with no pre-ticked box and no consent inherited from agreeing to something else. Building to both standards was the decision, since the storefront is publicly reachable and anyone can register.

So the marketing sentence is restored to exactly what it was, which leaves every existing email consent valid and untouched, and analytics gets its own column, its own sentence, its own checkbox at registration, its own toggle in the account page and its own endpoint. A customer can now hold either, both, or neither, and withdrawing one does not disturb the other.

The migration defaults analytics_consent to false, which is both the honest answer — none of the existing customers was ever asked — and what Law 25 requires. Nothing about this change opts anybody in.

Two details that are compliance requirements rather than wording preferences. The sentence names Brevo instead of saying "our email provider", because informed consent means the customer can tell who receives their data and a description they cannot act on is not disclosure. And the account toggle is as prominent and as easy to switch off as it is to switch on, because withdrawal has to be as easy as consenting.

The analytics endpoint is separate from the marketing one rather than a second field on it, so that a single call cannot change an answer the customer did not touch — the bundling problem moved from the form into the API. The unit tests now assert the two consents stay apart in both directions, including that the marketing sentence still says nothing about tracking, because re-bundling them would otherwise pass silently and is the mistake this project already made once.

Verified: backend tsc clean, both lint suites 0 errors with no new warnings, 478 unit tests passing across 33 suites, frontend production build green. Not verified: the migration has not been run against a database, and integration and e2e need a Node this machine does not have active. None of this is legal advice and the wording is worth a lawyer's eye before it ships.

Refs #56

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

frontend/src/customer/AuthForm.tsx

@@ -20,13 +20,17 @@ export type AuthMode = 'register' | 'login';
 // this was shared there were three wordings in play — this one, a shorter one in
 // the cart prompt, and the string the server actually recorded — and none of
 // them matched.
-//
-// Widened for #56 so it covers the Brevo tracker as well as email. The tracker
-// is gated on whether a customer's *stored* copy of this sentence matches the
-// current one, so changing it here does not retroactively widen the consent of
-// anyone who agreed to the previous wording.
 export const MARKETING_CONSENT_TEXT =
-  'I want to receive occasional emails about new one-of-a-kind items from Redefined Designs, and I agree that what I browse and buy here may be shared with our email provider to help choose what they contain. I can unsubscribe at any time.';
+  'I want to receive occasional emails about new one-of-a-kind items from Redefined Designs. I can unsubscribe at any time.';
+
+// Analytics consent (#56). A second sentence and a second checkbox rather than
+// wording folded into the one above, because GDPR requires consent to be
+// granular: someone must be able to take the emails and refuse the tracking.
+// Must stay identical to ANALYTICS_CONSENT_TEXT in backend/src/utils.ts, which
+// is what gets stored verbatim — same rule, and same failure mode, as the
+// marketing sentence.
+export const ANALYTICS_CONSENT_TEXT =
+  'I agree that what I browse and buy on this site may be shared with Brevo, the service that sends our emails, so that what they contain is relevant to me. This is optional, separate from receiving the emails themselves, and I can turn it off at any time.';
 
 type Props = Readonly<{
   mode: AuthMode;
@@ -81,7 +85,7 @@ export default function AuthForm({ mode, onModeChange, onForgotPassword, onSucce
                 layout="vertical"
                 onFinish={(values) =>
                   submit(() =>
-                    registerCustomer(values.email, values.password, values.firstName, values.lastName, !!values.marketingConsent)
+                    registerCustomer(values.email, values.password, values.firstName, values.lastName, !!values.marketingConsent, !!values.analyticsConsent)
                   )
                 }
               >
@@ -112,6 +116,14 @@ export default function AuthForm({ mode, onModeChange, onForgotPassword, onSucce
                 <Form.Item name="marketingConsent" valuePropName="checked" initialValue={false}>
                   <Checkbox>{MARKETING_CONSENT_TEXT}</Checkbox>
                 </Form.Item>
+                {/* Its own checkbox, and independent of the one above: someone
+                    has to be able to take the emails and refuse the tracking,
+                    or the consent is not granular and is not valid. Unchecked
+                    by default and never pre-ticked — Quebec's Law 25 requires
+                    profiling to be off until the person switches it on. */}
+                <Form.Item name="analyticsConsent" valuePropName="checked" initialValue={false}>
+                  <Checkbox>{ANALYTICS_CONSENT_TEXT}</Checkbox>
+                </Form.Item>
                 <Button type="primary" htmlType="submit" block loading={loading}>
                   Create account
                 </Button>