bermudalamb/redefined-designs
1
0
Fork 0
Code Issues 2 Pull Requests 1 Actions Packages Projects 3 Releases Wiki Activity

fix(e2e): match the modal OK button exactly so a random suffix cannot collide (#253)

Browse Source 
Playwright matches an accessible name case-insensitively and as a substring unless exact is passed, so `getByRole('button', { name: 'OK' })` matched any button whose name merely contained "ok".

Caught on a full serial run of main:

    strict mode violation: getByRole('button', { name: 'OK' }) resolved to 2 elements:
        1) aka getByRole('button', { name: 'Freed rmtiq9okg22k9e' })
        2) aka getByRole('button', { name: 'OK', exact: true })

A leftover "Freed …" toast was still on screen and the random base36 suffix happened to contain "ok". Roughly one suffix in a few hundred does, which is the profile of a test that fails occasionally and reproduces for nobody.

This is not the contention #241 addressed. It reproduced with workers: 1, serially, on a fresh database — it needs only a stale toast and an unlucky suffix. It is at least part of what #245 skipped a real test to work around.

Also makes the taxonomy modal's OK and the sold-filter 'All' radio exact, the only other targets short enough to appear inside a random suffix. The dozen or so remaining short names are left alone deliberately: they would need a collision in deliberately-chosen test data rather than a random one, and substring matching is load-bearing in some of them.

Verified with two consecutive full e2e passes, 155 of 155 both times.

Closes #253

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
bermudalamb
2026-09-01 09:42:37 -05:00
co-authored by Claude Opus 5
parent 8eba49c029
commit 94b2dfd186
3 changed files with 10 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
frontend/tests/e2e/pages/AdminTaxonomy.ts
+2 -1
View File
@@ -21,7 +21,8 @@ export class AdminTaxonomy {
this.addCategoryButton = page.getByRole('button', { name: 'Add Category' });
this.addTagButton = page.getByRole('button', { name: 'Add Tag' });
this.name = page.getByLabel('Name');
this.confirmButton = page.getByRole('button', { name: 'OK' });
// Substring matching would collide with random suffixes. See #253.
this.confirmButton = page.getByRole('button', { name: 'OK', exact: true });
this.tagAddedNotice = page.getByText('Tag added');
}