test(e2e): replace unchecked lookups, widen the assertion timeout, restore the skipped test (#241)
Tasks 2 to 4 of the plan. Nine `collection.find(...)` dereferences become findOrFail, so a missing row fails as a named assertion naming what was wanted and how many rows were searched, rather than "Cannot read properties of undefined" pointing at test plumbing. Where the old code followed the lookup with expect(x).toBeTruthy(), that assertion is dropped: findOrFail already guarantees it, and with a better message. The expect timeout goes from Playwright's default 5s to 10s. It costs nothing on a green run — it bounds how long a failing assertion waits, not how long a passing one takes — and #239 died reporting exactly Timeout: 5000ms on a runner that also builds, migrates and runs three other suites. The admin-save happy path comes back from the #245 skip. It is the only end-to-end check that adding an item reaches the database rather than merely firing a toast, and it passed both full parallel runs and in isolation. filters.spec.ts:216 is deliberately untouched: its .find() searches CSS class names on a string array, not test data, and has no missing-row failure mode. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
@@ -1,4 +1,4 @@
|
||||
import { test, expect, uniqueSuffix } from './fixtures';
|
||||
import { test, expect, uniqueSuffix, findOrFail } from './fixtures';
|
||||
|
||||
// The e2e database is shared and never reset, so every fixture name carries a
|
||||
// unique suffix and assertions are scoped to the nodes this run created. The
|
||||
@@ -41,8 +41,11 @@ test.describe('Admin taxonomy', () => {
|
||||
// The table paginates and the shared database holds many tags, so the new
|
||||
// row is confirmed through the API rather than hunted for across pages.
|
||||
const tags = await (await page.request.get('/api/admin/tags')).json();
|
||||
const created = tags.find((tag: { name: string }) => tag.name === `vintage-${RUN}`);
|
||||
expect(created).toBeTruthy();
|
||||
const created = findOrFail(
|
||||
tags,
|
||||
(tag: { name: string }) => tag.name === `vintage-${RUN}`,
|
||||
`the tag vintage-${RUN}`
|
||||
);
|
||||
expect(created.color).toBeTruthy();
|
||||
});
|
||||
|
||||
|
||||
Reference in New Issue
Block a user