bermudalamb/redefined-designs
1
0
Fork 0
Code Issues 2 Pull Requests 1 Actions Packages Projects 3 Releases Wiki Activity

test(e2e): replace unchecked lookups, widen the assertion timeout, restore the skipped test (#241)

Browse Source 
Tasks 2 to 4 of the plan. Nine `collection.find(...)` dereferences become findOrFail, so a missing row fails as a named assertion naming what was wanted and how many rows were searched, rather than "Cannot read properties of undefined" pointing at test plumbing. Where the old code followed the lookup with expect(x).toBeTruthy(), that assertion is dropped: findOrFail already guarantees it, and with a better message.

The expect timeout goes from Playwright's default 5s to 10s. It costs nothing on a green run — it bounds how long a failing assertion waits, not how long a passing one takes — and #239 died reporting exactly Timeout: 5000ms on a runner that also builds, migrates and runs three other suites.

The admin-save happy path comes back from the #245 skip. It is the only end-to-end check that adding an item reaches the database rather than merely firing a toast, and it passed both full parallel runs and in isolation.

filters.spec.ts:216 is deliberately untouched: its .find() searches CSS class names on a string array, not test data, and has no missing-row failure mode.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
bermudalamb
2026-08-31 20:04:43 -05:00
co-authored by Claude Opus 5
parent 93a451dbf0
commit 895c08d1a7
7 changed files with 69 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files
frontend/playwright.config.ts
+11
View File
@@ -14,6 +14,17 @@ export default defineConfig({
// that was plainly visible and enabled.
reducedMotion: 'reduce'
},
// Playwright's default is 5s, and nothing overrode it. That is generous on an
// idle laptop and tight on this runner: a full CI pass takes around 21.5
// minutes on a single machine that also builds, migrates and runs three other
// suites, and the #239 failure reported exactly `Timeout: 5000ms`.
//
// Costs nothing on a green run. This bounds how long a *failing* assertion
// waits before giving up, not how long a passing one takes — a locator that
// resolves in 200ms still resolves in 200ms.
expect: {
timeout: 10000
},
webServer: {
command: 'npm run dev',
url: 'http://localhost:5173',