bermudalamb/redefined-designs
1
0
Fork 0
Code Issues 2 Pull Requests 1 Actions Packages Projects 3 Releases Wiki Activity

docs(plan): correct the cumulative unit test counts (#188)

Browse Source 
Task 1 leaves 4 tests and Task 2 adds 7, so the running total is 11 rather than 12, and the same off-by-one carried into Tasks 3, 4 and the completion criteria. Caught by the Task 2 implementer, which flagged the mismatch rather than inventing a test to reach the stated number.
This commit is contained in:
bermudalamb
2026-08-25 15:07:13 -05:00
parent abd3dd4e2e
commit 60b76cae82
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
docs/superpowers/plans/2026-08-25-filter-dimensions.md
+5 -5
View File
@@ -505,7 +505,7 @@ export const priceDimension: FilterDimension = {
- [ ] **Step 5: Run the tests** - [ ] **Step 5: Run the tests**
Run: `npm run test:unit` Run: `npm run test:unit`
Expected: PASS, 12 tests. Expected: PASS, 11 tests.
- [ ] **Step 6: Type-check, lint and commit** - [ ] **Step 6: Type-check, lint and commit**
@@ -667,7 +667,7 @@ export const statusDimension: FilterDimension = {
- [ ] **Step 4: Run the tests** - [ ] **Step 4: Run the tests**
Run: `npm run test:unit` Run: `npm run test:unit`
Expected: PASS, 19 tests. Expected: PASS, 18 tests.
- [ ] **Step 5: Type-check, lint and commit** - [ ] **Step 5: Type-check, lint and commit**
@@ -799,7 +799,7 @@ export const availabilityDimension: FilterDimension = {
- [ ] **Step 4: Run the tests** - [ ] **Step 4: Run the tests**
Run: `npm run test:unit` Run: `npm run test:unit`
Expected: PASS, 23 tests. Expected: PASS, 22 tests.
- [ ] **Step 5: Type-check, lint and commit** - [ ] **Step 5: Type-check, lint and commit**
@@ -1199,7 +1199,7 @@ In `frontend/src/filters.ts`, delete `activeFilterCount` and `hasActiveFilters`
- [ ] **Step 5: Type-check, lint, unit** - [ ] **Step 5: Type-check, lint, unit**
Run: `npx tsc --noEmit && npx tsc -p tsconfig.test.json --noEmit && npm run lint && npm run test:unit` Run: `npx tsc --noEmit && npx tsc -p tsconfig.test.json --noEmit && npm run lint && npm run test:unit`
Expected: no errors, 23 unit tests pass. Any remaining reference to the deleted helpers is a compile error and names itself. Expected: no errors, 22 unit tests pass. Any remaining reference to the deleted helpers is a compile error and names itself.
- [ ] **Step 6: Verify the storefront end-to-end** - [ ] **Step 6: Verify the storefront end-to-end**
@@ -1286,7 +1286,7 @@ git commit -m "test(filters): cover the tally and availability chip behaviour ch
## Done when ## Done when
- `npm run test:unit` passes in `frontend/` with 23 tests. - `npm run test:unit` passes in `frontend/` with 22 tests.
- `npx tsc --noEmit`, `npx tsc -p tsconfig.test.json --noEmit` and `npm run lint` are clean in both workspaces. - `npx tsc --noEmit`, `npx tsc -p tsconfig.test.json --noEmit` and `npm run lint` are clean in both workspaces.
- `FilterDrawer.tsx`, `ActiveFilterChips.tsx`, `activeFilterCount` and `hasActiveFilters` no longer exist. - `FilterDrawer.tsx`, `ActiveFilterChips.tsx`, `activeFilterCount` and `hasActiveFilters` no longer exist.
- `admin-inventory-filters.spec.ts` passes in full; `filters.spec.ts` and `favorites-filter.spec.ts` pass except the two assertions blocked on #186. - `admin-inventory-filters.spec.ts` passes in full; `filters.spec.ts` and `favorites-filter.spec.ts` pass except the two assertions blocked on #186.