test(integration): mock the mailer everywhere an upload link is issued (#260)

intake.integration.test.ts, intakeCeiling.integration.test.ts and uploadLinks.integration.test.ts all create upload links, and since #260 that now sends real mail. env.setup.ts never clears SMTP_USER, SMTP_PASSWORD or MAIL_ALLOWLIST, so with those inherited from a developer's shell these three files opened live TLS connections to smtp.gmail.com:465 and, with no allowlist set, actually delivered to sarah@example.com. This is the exact hazard the "Do not add one back" comment in tests/unit/mailOutcome.test.ts already warns about, reintroduced at the integration layer.

All three now mock ../../src/mailer the same way accountDetails.integration.test.ts, favorites.integration.test.ts and resendVerification.integration.test.ts already do. uploadLinks.integration.test.ts is the one place that needs to see specific MailOutcome values come back through the route, so its two outcome tests were restructured to drive the mock's return value directly (sentMail.mockResolvedValueOnce(...)) instead of threading SMTP_USER/MAIL_ALLOWLIST through the real sendMail. That is a cleaner test anyway: it isolates the route's job (reporting whatever outcome sendMail returns) from sendMail's own skip logic, which is already covered hermetically by mailOutcome.test.ts and mailAllowlist.test.ts.

Also addresses the related minor finding that nothing asserted the mail actually carried the working link: required: ['submitUrl'] on the template only guards that the placeholder is present in the body, not that the route supplied a correct value for it. A new test in uploadLinks.integration.test.ts inspects the mock's captured call and asserts the html contains the created token's /submit/ URL, and covers the three submissionsAllowed phrasings (a numeric cap, a cap of exactly one, and uncapped).

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

This commit is contained in:

bermudalamb

2026-09-03 18:30:35 -05:00

co-authored by

Claude Opus 5

parent 9c5935e8e0

commit 5a9022d8d1

3 changed files with 93 additions and 30 deletions

									
										backend/tests/integration/intake.integration.test.ts
									
		+8
		
												View File
												
				@@ -4,6 +4,14 @@ import app from '../../src/app';

				import { pool } from '../../src/db';

				import { resetDb, closeDb } from './setup/testDb';

				// Every submission-cap test here issues a link, which now emails it. Mocked

				// so the suite never opens a real connection to smtp.gmail.com — see the

				// "Do not add one back" warning in tests/unit/mailOutcome.test.ts, which this

				// mirrors at the integration layer.

				jest.mock('../../src/mailer', () => ({

				  sendMail: jest.fn().mockResolvedValue('sent')

				}));

				const UPLOADS_DIR = process.env.UPLOADS_DIR as string;

				// The same 1x1 PNG the upload validation suite uses, so the accepted case