fix(orders): mark a demo order in the history rather than leaving it to read as real (#205)
Linting / lint (pull_request) Successful in 2m13s
SonarQube Analysis / sonarqube (pull_request) Failing after 16m22s

#195 and #203 made the cart say a demo order is a demo order. That message is an antd toast lasting about three seconds, after which the cart empties and the card unmounts. Order history is what the customer comes back to when they wonder where their item is, and it said nothing.

A demo row was a real row: item name, `$80.00`, status `completed` rendered as a neutral tag because `STATUS_COLORS` has no `completed` key, and `demo` printed raw under a heading reading "Processor". That is not an explanation — a customer has no reason to read `demo` as "this did not happen", and "processor" is not a word they have any reason to know.

Two things now say it, for the same reason the cart needed two. The `demo` cell renders as a tag reading "Demo (not charged)", which marks *which* order. A notice above the table, shown only when there is one, says what that means — a tag reading "Demo" still assumes the reader knows what a demo order is, and what they actually want to know is whether to expect a parcel.

Nothing changes on the backend: `orders.processor = 'demo'` was already written at checkout and already selected for this page. The row is a real row in a real table and stays visible, because hiding it would be its own kind of lie — the customer did do something, and it did have an effect on the catalogue.

Written test-first against a browser: the new case drives a real demo purchase through the cart, opens `/orders`, and failed on both assertions before the change.

Verified: 4 end-to-end tests in this spec pass, the 5 existing order-history tests still pass, frontend build clean, lint 0 errors (2 pre-existing warnings in `src/filters.ts`).

Closes #205

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
2026-08-28 12:22:39 -05:00
co-authored by Claude Opus 5
parent f0bdc590c9
commit 39c82ff3a4
3 changed files with 66 additions and 10 deletions
+36 -10
View File
@@ -38,7 +38,16 @@ const COLUMNS = [
dataIndex: 'status',
render: (v: string) => <Tag color={STATUS_COLORS[v]}>{v}</Tag>
},
{ title: 'Processor', dataIndex: 'processor' },
{
title: 'Processor',
dataIndex: 'processor',
// `demo` used to render as a raw column value, which is not an explanation:
// a customer has no reason to read it as "this did not happen", and the row
// was otherwise identical to a real one — real price, `completed` status,
// same neutral tag. The cart says it is a demo (#195, #203) for about three
// seconds; this is the record they come back to. See #205.
render: (v: string) => (v === 'demo' ? <Tag color="warning">Demo (not charged)</Tag> : v)
},
{ title: 'Date', dataIndex: 'created_at', render: (v: string) => new Date(v).toLocaleDateString() }
];
@@ -69,6 +78,12 @@ function OrdersBody({ loading, error, orders, onRetry }: BodyProps) {
);
}
// Shown only when there is one to explain. The per-row tag says which order,
// this says what it means — a tag reading "Demo" still assumes the reader
// knows what a demo order is, and the thing they actually want to know is
// whether to expect a parcel.
const hasDemoOrder = orders.some(o => o.processor === 'demo');
if (orders.length === 0) {
return (
<Space direction="vertical" align="center" style={{ width: '100%', marginTop: 24 }}>
@@ -79,15 +94,26 @@ function OrdersBody({ loading, error, orders, onRetry }: BodyProps) {
}
return (
<Table
rowKey="id"
dataSource={orders}
pagination={false}
// Still correct on a phone. It is no longer compensating for being in a
// modal narrower than its own content.
scroll={{ x: 'max-content' }}
columns={COLUMNS}
/>
<>
{hasDemoOrder && (
<Alert
type="warning"
showIcon
style={{ marginBottom: 16 }}
message="Some of these are demo orders"
description="A demo order is a pretend one: nothing was charged, and nothing will be shipped."
/>
)}
<Table
rowKey="id"
dataSource={orders}
pagination={false}
// Still correct on a phone. It is no longer compensating for being in a
// modal narrower than its own content.
scroll={{ x: 'max-content' }}
columns={COLUMNS}
/>
</>
);
}