fix(backend): route every async handler through the error middleware (#59)

Express 4 does not forward a rejected promise from an async handler, so an unwrapped async route never responds at all — the request hangs until the client gives up, nothing reaches the error middleware, and monitoring sees an open connection rather than a 500. That silence is the shape of the 2026-08-17 incident, where an unhandled rejection left every item query hanging and the storefront rendered it as an empty shop. `asyncRoute` was written in response, but it was only applied to some routes: 30 handlers added afterwards were still bare, including register, login, the whole cart, and PayPal checkout.

Wraps all 30, plus two the issue's inventory missed. `attachCustomer` is a bare async middleware mounted globally in app.ts, so a rejection in its session lookup would hang every request in the application — including the 25 handlers that were already wrapped correctly, which meant the guarantee did not actually hold anywhere. The PayPal webhook registers on a second router named `webhookRouter`, so an audit grepping for `router.` walked straight past it.

Adds a unit test that scans the route sources and fails on any registration whose handler is not wrapped. A convention already half-forgotten once will be forgotten again, and enforcement is what the issue asked for; ESLint would be the better home for it but there is no ESLint in this repo yet (#60). The test walks parens rather than lines, so it also catches a handler whose `async` sits on its own line, and it matches any `*Router` name rather than just `router` — the two ways the existing bare handlers escaped notice. It is deleted along with `asyncRoute` if the project moves to Express 5, which forwards rejections natively.

No behaviour changes on the success path; the failure path turns a hung request into a logged 500.

Closes #59

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

backend/src/routes/shippingAddresses.ts

@@ -1,19 +1,20 @@
 import { Router, Request, Response } from 'express';
 import { pool } from '../db';
+import { asyncRoute } from '../asyncRoute';
 import { requireCustomer } from '../middleware/customerAuth';
 import { validateAddress, uspsConfigured, UspsValidationResult } from '../usps';
 
 const router = Router();
 
-router.get('/', requireCustomer, async (req: Request, res: Response) => {
+router.get('/', requireCustomer, asyncRoute(async (req: Request, res: Response) => {
   const { rows } = await pool.query(
     `SELECT * FROM shipping_addresses WHERE customer_id = $1 ORDER BY is_default DESC, created_at DESC`,
     [req.customerId]
   );
   res.json(rows);
-});
+}));
 
-router.post('/', requireCustomer, async (req: Request, res: Response) => {
+router.post('/', requireCustomer, asyncRoute(async (req: Request, res: Response) => {
   const { fullName, addressLine1, addressLine2, city, state, postalCode, country, isDefault } = req.body;
   if (!fullName || !addressLine1 || !city || !state || !postalCode) {
     return res.status(400).json({ error: 'fullName, addressLine1, city, state, and postalCode are required' });
@@ -48,9 +49,9 @@ if ((country || 'US') === 'US') {
   } finally {
     client.release();
   }
-});
+}));
 
-router.put('/:id', requireCustomer, async (req: Request, res: Response) => {
+router.put('/:id', requireCustomer, asyncRoute(async (req: Request, res: Response) => {
   const { fullName, addressLine1, addressLine2, city, state, postalCode, country, isDefault } = req.body;
   const client = await pool.connect();
   try {
@@ -75,14 +76,14 @@ router.put('/:id', requireCustomer, async (req: Request, res: Response) => {
   } finally {
     client.release();
   }
-});
+}));
 
-router.delete('/:id', requireCustomer, async (req: Request, res: Response) => {
+router.delete('/:id', requireCustomer, asyncRoute(async (req: Request, res: Response) => {
   await pool.query(`DELETE FROM shipping_addresses WHERE id = $1 AND customer_id = $2`, [req.params.id, req.customerId]);
   res.status(204).end();
-});
+}));
 
-router.post('/:id/set-default', requireCustomer, async (req: Request, res: Response) => {
+router.post('/:id/set-default', requireCustomer, asyncRoute(async (req: Request, res: Response) => {
   const client = await pool.connect();
   try {
     await client.query('BEGIN');
@@ -99,6 +100,6 @@ router.post('/:id/set-default', requireCustomer, async (req: Request, res: Respo
   } finally {
     client.release();
   }
-});
+}));
 
 export default router;