Thom LambandClaude Opus 4.7
f55d8130e6
SonarQube Analysis / sonarqube (pull_request) Successful in 3m41s
- **NUnit2046 (15)**: extend the prior regex sweep to also catch the
`Is.GreaterThan(n)` / `Is.GreaterThanOrEqualTo(n)` variants on
`.Count` and `.Length` — the previous pass only handled `Is.EqualTo`.
Affects PG/Snowflake `QueryBreakdownTests`, PG `StatementReaderTests`,
`LinqToSql` `QueryComparatorTests` / `QueryValidatorTests`,
`Markdown.Tests` `ExpressionGeneratorTests` /
`QueryBreakdownGeneratorTests`, and `JsonTokenReaderTests`.
- **CS8604 (8)**: `merged[someKey]` access inside `Assert.Multiple(() =>
{ ... })` lambdas where `someKey` is `string?` from `FirstOrDefault`.
The preceding `Assert.That(someKey, Is.Not.Null)` does not propagate
null-narrowing into the lambda scope, so add `!` to the dictionary
index. (Tests fail loud with a meaningful message if the key really
is null, so this is safe.)
- **NUnit2045 (1)**: wrap a four-assert block in
`JsonTokenReaderTests.cs:65-68` in `Assert.Multiple`. Mirrors the
surrounding two `Assert.Multiple` groups in that method.
All 1180 tests stay green.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
74 lines
2.9 KiB
C#
74 lines
2.9 KiB
C#
using System.Text;
|
|
using System.Text.Json;
|
|
|
|
namespace Strata.SqlTools.SqlBreakdown.Tests;
|
|
|
|
[TestFixture]
|
|
public class JsonTokenReaderTests
|
|
{
|
|
[Test]
|
|
public void JsonTokenReader_ReadsJsonTokensCorrectly()
|
|
{
|
|
// Arrange
|
|
var jsonString = """
|
|
{
|
|
"foo": "bar",
|
|
"myList": [1,2,3,4],
|
|
"another": 12
|
|
}
|
|
""";
|
|
var jsonBytes = Encoding.UTF8.GetBytes(jsonString);
|
|
var reader = new Utf8JsonReader(jsonBytes);
|
|
var tokens = new List<(JsonTokenType Type, string Value)>();
|
|
|
|
// Act
|
|
while (reader.Read())
|
|
{
|
|
var tokenValue = Encoding.UTF8.GetString(reader.ValueSpan);
|
|
tokens.Add((reader.TokenType, tokenValue));
|
|
}
|
|
|
|
// Assert - Validate JSON shape and structure
|
|
Assert.That(tokens, Is.Not.Empty);
|
|
|
|
// Validate JSON starts with StartObject and ends with EndObject
|
|
Assert.That(tokens, Has.Count.GreaterThan(2));
|
|
Assert.Multiple(() =>
|
|
{
|
|
Assert.That(tokens[0].Type, Is.EqualTo(JsonTokenType.StartObject));
|
|
Assert.That(tokens[^1].Type, Is.EqualTo(JsonTokenType.EndObject));
|
|
Assert.That(tokens.Count(t => t.Type == JsonTokenType.PropertyName && t.Value == "foo"), Is.EqualTo(1));
|
|
Assert.That(tokens.Count(t => t.Type == JsonTokenType.String && t.Value == "bar"), Is.EqualTo(1));
|
|
Assert.That(tokens.Count(t => t.Type == JsonTokenType.PropertyName && t.Value == "myList"), Is.EqualTo(1));
|
|
Assert.That(tokens.Count(t => t.Type == JsonTokenType.StartArray), Is.EqualTo(1));
|
|
Assert.That(tokens.Count(t => t.Type == JsonTokenType.PropertyName && t.Value == "another"), Is.EqualTo(1));
|
|
Assert.That(tokens.Count(t => t.Type == JsonTokenType.Number && t.Value == "12"), Is.EqualTo(1));
|
|
});
|
|
|
|
// Deep validation of JSON content structure
|
|
var tokenIndex = 4;
|
|
|
|
Assert.Multiple(() =>
|
|
{
|
|
// Token 4: [
|
|
Assert.That(tokens[tokenIndex++].Type, Is.EqualTo(JsonTokenType.StartArray));
|
|
|
|
// Token 5-8: Array elements [1,2,3,4]
|
|
Assert.That(tokens[tokenIndex].Type, Is.EqualTo(JsonTokenType.Number));
|
|
Assert.That(tokens[tokenIndex++].Value, Is.EqualTo("1"));
|
|
});
|
|
Assert.Multiple(() =>
|
|
{
|
|
Assert.That(tokens[tokenIndex].Type, Is.EqualTo(JsonTokenType.Number));
|
|
Assert.That(tokens[tokenIndex++].Value, Is.EqualTo("2"));
|
|
});
|
|
Assert.That(tokens[tokenIndex].Type, Is.EqualTo(JsonTokenType.Number));
|
|
Assert.That(tokens[tokenIndex++].Value, Is.EqualTo("3"));
|
|
Assert.That(tokens[tokenIndex].Type, Is.EqualTo(JsonTokenType.Number));
|
|
Assert.That(tokens[tokenIndex++].Value, Is.EqualTo("4"));
|
|
|
|
// Token 9: ]
|
|
Assert.That(tokens[tokenIndex].Type, Is.EqualTo(JsonTokenType.EndArray));
|
|
}
|
|
}
|