SonarQube Analysis / sonarqube (pull_request) Successful in 3m30s
Three public methods on the SqlServer-namespaced Markdown generators no longer touch instance state and now carry the `static` keyword: - `Markdown.SqlServer.QueryBreakdownGenerator.GenerateMermaidDiagram(QueryBreakdown, string?)` - `Markdown.SqlServer.SqlStatementGenerator.GenerateSequenceDiagram(ISqlBreakdown, string?)` - `Markdown.SqlServer.SqlStatementGenerator.GenerateEntityRelationshipDiagram(IEnumerable<string>, string?)` Plus one private bonus the analyzer caught on the same pass: - `LinqExpressionVisitor.ExtractSelectExpression` → static (non-breaking). Internal callers in the Snowflake/LinqToSql/PostgreSql wrapper classes and in the test fixtures are updated to the type-name form (`SqlServer.SqlStatementGenerator.GenerateSequenceDiagram(...)`). The wrappers retain their `_baseGenerator` field for now even though it is no longer used — that S4487 / unused-field cleanup is its own commit. BREAKING CHANGE: External NuGet consumers calling `generatorInstance.GenerateMermaidDiagram(...)`, `generatorInstance.GenerateSequenceDiagram(...)`, or `generatorInstance.GenerateEntityRelationshipDiagram(...)` on the SqlServer-namespaced generators must switch to type-name form, e.g. `Markdown.SqlServer.SqlStatementGenerator.GenerateSequenceDiagram(...)`. Calls through the Snowflake / LinqToSql / PostgreSql wrapper classes are unaffected at the call site. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
125 lines
3.7 KiB
C#
125 lines
3.7 KiB
C#
using Strata.SqlTools.Breakdowns.SqlServer;
|
|
using Strata.SqlTools.Markdown.SqlServer;
|
|
|
|
namespace Strata.SqlTools.Markdown.Tests.SqlServer;
|
|
|
|
[TestFixture]
|
|
public class SqlStatementGeneratorTests
|
|
{
|
|
private SqlStatementGenerator _generator = null!;
|
|
|
|
[SetUp]
|
|
public void Setup()
|
|
{
|
|
_generator = new SqlStatementGenerator();
|
|
}
|
|
|
|
[Test]
|
|
public void GenerateSequenceDiagram_WithSimpleQuery_GeneratesSequence()
|
|
{
|
|
// Arrange
|
|
var query = new QueryBreakdown("*", "Users");
|
|
|
|
// Act
|
|
var result = SqlStatementGenerator.GenerateSequenceDiagram(query);
|
|
|
|
// Assert
|
|
Assert.That(result, Does.Contain("```mermaid"));
|
|
Assert.That(result, Does.Contain("sequenceDiagram"));
|
|
Assert.That(result, Does.Contain("App->>DB"));
|
|
Assert.That(result, Does.Contain("DB-->>App"));
|
|
Assert.That(result, Does.Contain("```"));
|
|
}
|
|
|
|
[Test]
|
|
public void GenerateSequenceDiagram_WithSetupClauses_IncludesSetup()
|
|
{
|
|
// Arrange
|
|
var query = new QueryBreakdown("*", "Users");
|
|
query.SetupClauses.Add("CREATE TEMP TABLE #Temp (ID INT)");
|
|
|
|
// Act
|
|
var result = SqlStatementGenerator.GenerateSequenceDiagram(query);
|
|
|
|
// Assert
|
|
Assert.That(result, Does.Contain("Setup Clauses"));
|
|
Assert.That(result, Does.Contain("activate DB"));
|
|
Assert.That(result, Does.Contain("deactivate DB"));
|
|
}
|
|
|
|
[Test]
|
|
public void GenerateSequenceDiagram_WithFinishClauses_IncludesFinish()
|
|
{
|
|
// Arrange
|
|
var query = new QueryBreakdown("*", "Users");
|
|
query.FinishClauses.Add("DROP TABLE #Temp");
|
|
|
|
// Act
|
|
var result = SqlStatementGenerator.GenerateSequenceDiagram(query);
|
|
|
|
// Assert
|
|
Assert.That(result, Does.Contain("Finish Clauses"));
|
|
Assert.That(result, Does.Contain("Cleanup"));
|
|
}
|
|
|
|
[Test]
|
|
public void GenerateSequenceDiagram_WithTitle_IncludesTitle()
|
|
{
|
|
// Arrange
|
|
var query = new QueryBreakdown("*", "Users");
|
|
|
|
// Act
|
|
var result = SqlStatementGenerator.GenerateSequenceDiagram(query, "Query Execution");
|
|
|
|
// Assert
|
|
Assert.That(result, Does.StartWith("### Query Execution"));
|
|
}
|
|
|
|
[Test]
|
|
public void GenerateEntityRelationshipDiagram_WithTables_GeneratesERDiagram()
|
|
{
|
|
// Arrange
|
|
var tables = new[] { "Users", "Orders", "Products" };
|
|
|
|
// Act
|
|
var result = SqlStatementGenerator.GenerateEntityRelationshipDiagram(tables);
|
|
|
|
// Assert
|
|
Assert.That(result, Does.Contain("```mermaid"));
|
|
Assert.That(result, Does.Contain("erDiagram"));
|
|
Assert.That(result, Does.Contain("Users"));
|
|
Assert.That(result, Does.Contain("Orders"));
|
|
Assert.That(result, Does.Contain("Products"));
|
|
Assert.That(result, Does.Contain("```"));
|
|
}
|
|
|
|
[Test]
|
|
public void GenerateEntityRelationshipDiagram_WithTitle_IncludesTitle()
|
|
{
|
|
// Arrange
|
|
var tables = new[] { "Users", "Orders" };
|
|
|
|
// Act
|
|
var result = SqlStatementGenerator.GenerateEntityRelationshipDiagram(tables, "Database Schema");
|
|
|
|
// Assert
|
|
Assert.That(result, Does.StartWith("### Database Schema"));
|
|
}
|
|
|
|
[Test]
|
|
public void GenerateEntityRelationshipDiagram_CleansTableNames()
|
|
{
|
|
// Arrange
|
|
var tables = new[] { "[dbo].[Users]", "schema.Orders" };
|
|
|
|
// Act
|
|
var result = SqlStatementGenerator.GenerateEntityRelationshipDiagram(tables);
|
|
|
|
// Assert
|
|
Assert.That(result, Does.Contain("dbo_Users"));
|
|
Assert.That(result, Does.Contain("schema_Orders"));
|
|
Assert.That(result, Does.Not.Contain("["));
|
|
Assert.That(result, Does.Not.Contain("]"));
|
|
}
|
|
}
|