Thom LambandClaude Opus 4.7
6175dcde96
SonarQube Analysis / sonarqube (pull_request) Successful in 2m50s
Commit 5202d93 made the SqlServer-namespaced Markdown generator methods
static, which left the LinqToSql / PostgreSql / Snowflake wrapper
classes' instance methods delegating to nothing but a static call.
SonarQube re-flagged those 10 wrapper methods as CA1822 on the next
scan.
This sweep:
- Makes all 10 wrapper instance methods `static` (`dotnet format` driven).
- Makes `Markdown.LinqToSql.QueryBreakdownGenerator.GenerateCombinedDiagram`
static preemptively — it composes two static helpers and would otherwise
be the next-iteration cascade flag.
- Removes the now-dead `_baseGenerator` field and its initializing
constructor from all six dialect wrappers (LinqToSql / PostgreSql /
Snowflake × QueryBreakdownGenerator + SqlStatementGenerator). The
classes keep their implicit parameterless constructor so `new
Snowflake.QueryBreakdownGenerator()` still compiles.
- Updates the one test call site (`GenerateCombinedDiagram`) the fixer
didn't catch to use type-name form.
BREAKING CHANGE: External NuGet consumers calling
`instance.Generate*Diagram(...)` on `Markdown.LinqToSql.*`,
`Markdown.PostgreSql.*`, or `Markdown.Snowflake.*` generators must
switch to type-name form, e.g. `Markdown.Snowflake.SqlStatementGenerator.GenerateSequenceDiagram(...)`.
The class types and parameterless constructors remain — only the call
syntax for these methods changes.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
113 lines
3.5 KiB
C#
113 lines
3.5 KiB
C#
using Strata.SqlTools.Markdown.LinqToSql;
|
|
using Strata.SqlTools.Breakdowns.LinqToSql;
|
|
|
|
namespace Strata.SqlTools.Markdown.Tests.LinqToSql;
|
|
|
|
[TestFixture]
|
|
public class SqlStatementGeneratorTests
|
|
{
|
|
private SqlStatementGenerator _generator = null!;
|
|
|
|
[SetUp]
|
|
public void Setup()
|
|
{
|
|
_generator = new SqlStatementGenerator();
|
|
}
|
|
|
|
[Test]
|
|
public void GenerateLinqPipelineDiagram_BasicQuery_GeneratesSequenceDiagram()
|
|
{
|
|
// Arrange
|
|
var query = new LinqQueryBreakdown("*", "Users");
|
|
|
|
// Act
|
|
var result = SqlStatementGenerator.GenerateLinqPipelineDiagram(query, "User Query Pipeline");
|
|
|
|
// Assert
|
|
Assert.That(result, Does.Contain("```mermaid"));
|
|
Assert.That(result, Does.Contain("sequenceDiagram"));
|
|
Assert.That(result, Does.Contain("### User Query Pipeline"));
|
|
Assert.That(result, Does.Contain("LINQ Provider"));
|
|
Assert.That(result, Does.Contain("Expression Tree"));
|
|
Assert.That(result, Does.Contain("SQL Generator"));
|
|
Assert.That(result, Does.Contain("Database"));
|
|
Assert.That(result, Does.Contain("```"));
|
|
}
|
|
|
|
[Test]
|
|
public void GenerateLinqPipelineDiagram_WithWhere_ShowsPredicateProcessing()
|
|
{
|
|
// Arrange
|
|
var query = new LinqQueryBreakdown("Id, Name", "Users");
|
|
query.AddWhereClause("Age > 21");
|
|
|
|
// Act
|
|
var result = SqlStatementGenerator.GenerateLinqPipelineDiagram(query);
|
|
|
|
// Assert
|
|
Assert.That(result, Does.Contain("Where Predicate"));
|
|
Assert.That(result, Does.Contain("Expression Tree"));
|
|
Assert.That(result, Does.Contain("SQL Generator"));
|
|
}
|
|
|
|
[Test]
|
|
public void GenerateLinqPipelineDiagram_WithProjection_ShowsSelectProcessing()
|
|
{
|
|
// Arrange
|
|
var query = new LinqQueryBreakdown("Id, Name, Email", "Users");
|
|
|
|
// Act
|
|
var result = SqlStatementGenerator.GenerateLinqPipelineDiagram(query);
|
|
|
|
// Assert
|
|
Assert.That(result, Does.Contain("Select Projection"));
|
|
Assert.That(result, Does.Contain("LINQ Provider"));
|
|
Assert.That(result, Does.Contain("Database"));
|
|
}
|
|
|
|
[Test]
|
|
public void GenerateLinqPipelineDiagram_NullTitle_GeneratesWithoutTitle()
|
|
{
|
|
// Arrange
|
|
var query = new LinqQueryBreakdown("*", "Users");
|
|
|
|
// Act
|
|
var result = SqlStatementGenerator.GenerateLinqPipelineDiagram(query, null);
|
|
|
|
// Assert
|
|
Assert.That(result, Does.Not.Contain("###"));
|
|
Assert.That(result, Does.Contain("```mermaid"));
|
|
Assert.That(result, Does.Contain("sequenceDiagram"));
|
|
}
|
|
|
|
[Test]
|
|
public void GenerateSequenceDiagram_DelegatesToBaseClass()
|
|
{
|
|
// Arrange
|
|
var query = new LinqQueryBreakdown("*", "Users");
|
|
|
|
// Act
|
|
var result = SqlStatementGenerator.GenerateSequenceDiagram(query, "Sequence Test");
|
|
|
|
// Assert
|
|
Assert.That(result, Does.Contain("```mermaid"));
|
|
Assert.That(result, Does.Contain("sequenceDiagram"));
|
|
Assert.That(result, Does.Contain("### Sequence Test"));
|
|
}
|
|
|
|
[Test]
|
|
public void GenerateEntityRelationshipDiagram_DelegatesToBaseClass()
|
|
{
|
|
// Arrange
|
|
var query = new LinqQueryBreakdown("Id, Name", "Users");
|
|
|
|
// Act
|
|
var result = SqlStatementGenerator.GenerateEntityRelationshipDiagram(query, "ER Test");
|
|
|
|
// Assert
|
|
Assert.That(result, Does.Contain("```mermaid"));
|
|
Assert.That(result, Does.Contain("erDiagram"));
|
|
Assert.That(result, Does.Contain("### ER Test"));
|
|
}
|
|
}
|