Thom Lamb
82af7b8de1
SonarQube Analysis / sonarqube (pull_request) Successful in 3m9s
Refactors the `CalculationFilterGroup` class to utilize C# primary constructors and property initializers, improving conciseness and readability. The `IsValid()` method's logic is updated. Previously, it returned true if *any* filter in the group was valid. Now, it returns true only if *all* filters are valid, and an empty filter group is considered valid. This adjustment clarifies the group's validity criteria, aligning with common interpretations for `All` operations and addressing related technical debt.
27 lines
726 B
C#
27 lines
726 B
C#
using System.Text.Json.Serialization;
|
|
|
|
namespace Strata.SqlTools.Query;
|
|
|
|
[method: JsonConstructor]
|
|
public class CalculationFilterGroup(IEnumerable<CalculationFilter> filters, LogicalOperator logicalOperator)
|
|
{
|
|
// Hereditary logical operation applied to all Filters
|
|
public LogicalOperator LogicalOperator { get; set; } = logicalOperator;
|
|
|
|
public IEnumerable<CalculationFilter> Filters { get; set; } = filters;
|
|
|
|
public CalculationFilterGroup() : this([], LogicalOperator.And)
|
|
{
|
|
}
|
|
|
|
public IEnumerable<CalculationFilter> GetValidFilters()
|
|
{
|
|
return Filters?.Where(x => x.IsValid()).ToList() ?? [];
|
|
}
|
|
|
|
public bool IsValid()
|
|
{
|
|
return Filters.All(x => x.IsValid());
|
|
}
|
|
}
|