Files
sql-utilities/tests/Strata.SqlTools.SqlBreakdown.Tests/ExpressionTests/BooleanExpressionTests.cs
T
Thom LambandClaude Opus 4.7 67512d23e1 chore(sonar): wrap independent assertions in Assert.Multiple (NUnit2045)
Driven by `dotnet format analyzers --diagnostics NUnit2045`. The fixer
groups consecutive independent `Assert.That(...)` calls into
`Assert.Multiple(() => { ... })`, so a failing assertion no longer
short-circuits the block — every failure inside the group is reported,
which gives much better diagnostics on multi-property tests.

Audit confirmed no Assert.Throws / Assert.Fail / Assert.Catch / Assert.Pass
/ Assert.DoesNotThrow got pulled inside a Multiple block (those need to
short-circuit). All 1180 tests pass.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-27 11:59:47 -05:00

138 lines
5.5 KiB
C#

using Strata.SqlTools.SqlBreakdown.Classes;
using Strata.SqlTools.SqlBreakdown.Expressions;
using Strata.SqlTools.SqlBreakdown.Expressions.Conditional;
using Strata.SqlTools.SqlBreakdown.Expressions.Conditional.Comparisons;
using Strata.SqlTools.SqlBreakdown.Expressions.Conditional.Logical;
namespace Strata.SqlTools.SqlBreakdown.Tests.ExpressionTests;
[TestFixture]
public class BooleanExpressionTests : ExpressionTestsBase
{
[Test]
public void BooleanExpression_AndOperator_ChainsCorrectly()
{
// Arrange
var greaterThan250Exp = new GreaterThanExpression(_costColumnExp, 250);
BooleanExpression original = BooleanExpression.False;
// Act
original &= greaterThan250Exp;
var firstResult = original;
original &= greaterThan250Exp;
var secondResult = original;
// Assert
Assert.That(firstResult, Is.Not.SameAs(BooleanExpression.False));
Assert.Multiple(() =>
{
Assert.That(firstResult, Is.AssignableTo<BooleanExpression>());
Assert.That(secondResult, Is.Not.SameAs(BooleanExpression.False));
});
Assert.That(secondResult, Is.TypeOf<AndExpression>());
}
[Test]
public void BooleanExpression_ComplexWithOperators_CreatesExpression()
{
// Arrange
var paramFoobar = new ParameterExpression("FOOBAR");
// Act
#pragma warning disable S2178 // Short-circuit logic should be used in boolean contexts
var andComp = _revenueColumnExp > 100 & _costColumnExp >= 250 | _nameColumnExp == paramFoobar;
#pragma warning restore S2178
// Assert
Assert.That(andComp, Is.Not.Null);
Assert.That(andComp, Is.AssignableTo<BooleanExpression>());
}
private static IEnumerable<TestCaseData> BooleanExpressionTestCases()
{
var testCases = new[]
{
new ExpressionTestCase
{
Name = "GreaterThan_{m}",
Arrange = new Dictionary<string, Expression>
{
["revenue"] = new RegisteredTableColumnExpression(2, "NET_REVENUE", new RegisteredTableSource(101, "CLIENT_DSS", "DEPT", "PES"))
},
Act = (columns, visitor) =>
{
var revenue = columns["revenue"];
var greaterThan100Exp = new GreaterThanExpression(revenue, 100);
return greaterThan100Exp;
},
Assertions = result =>
{
var expression = (BooleanExpression)result;
Assert.That(expression, Is.Not.Null);
Assert.That(expression, Is.TypeOf<GreaterThanExpression>());
return true;
}
},
new ExpressionTestCase
{
Name = "And_{m}",
Arrange = new Dictionary<string, Expression>
{
["revenue"] = new RegisteredTableColumnExpression(2, "NET_REVENUE", new RegisteredTableSource(101, "CLIENT_DSS", "DEPT", "PES")),
["cost"] = new RegisteredTableColumnExpression(3, "COST", new RegisteredTableSource(101, "CLIENT_DSS", "DEPT", "PES"))
},
Act = (columns, visitor) =>
{
var revenue = columns["revenue"];
var cost = columns["cost"];
var greaterThan100Exp = new GreaterThanExpression(revenue, 100);
var greaterThan250Exp = new GreaterThanExpression(cost, 250);
var andExp1 = new AndExpression(greaterThan100Exp, greaterThan250Exp);
return andExp1;
},
Assertions = result =>
{
var expression = (BooleanExpression)result;
Assert.That(expression, Is.Not.Null);
Assert.That(expression, Is.TypeOf<AndExpression>());
return true;
}
},
new ExpressionTestCase
{
Name = "Or_{m}",
Arrange = new Dictionary<string, Expression>
{
["revenue"] = new RegisteredTableColumnExpression(2, "NET_REVENUE", new RegisteredTableSource(101, "CLIENT_DSS", "DEPT", "PES")),
["cost"] = new RegisteredTableColumnExpression(3, "COST", new RegisteredTableSource(101, "CLIENT_DSS", "DEPT", "PES"))
},
Act = (columns, visitor) =>
{
var revenue = columns["revenue"];
var cost = columns["cost"];
#pragma warning disable S2178 // Short-circuit logic should be used in boolean contexts
var orComp = revenue > 100 | cost >= 250;
#pragma warning restore S2178
return orComp;
},
Assertions = result =>
{
var expression = (BooleanExpression)result;
Assert.That(expression, Is.Not.Null);
Assert.That(expression, Is.AssignableTo<BooleanExpression>());
return true;
}
}
};
foreach (var testCase in testCases)
{
yield return new TestCaseData(testCase).SetName(testCase.Name);
}
}
[TestCaseSource(nameof(BooleanExpressionTestCases))]
public void BooleanExpression_GeneratesCorrectExpression(ExpressionTestCase testCase)
=> ExecuteExpressionTest(testCase);
}