Resolve 8 critical SonarQube issues (BLOCKER + CRITICAL non-S3776) #2

Merged
bermudalamb merged 10 commits from fix/Sonarqube-Tech-Debt into main 2026-05-19 17:26:28 -05:00
Showing only changes of commit f96161a664 - Show all commits
@@ -1,6 +1,6 @@
using Strata.SqlTools.Visitors.PostgreSql; using Strata.SqlTools.Visitors.PostgreSql;
namespace Strata.SqlTools.PostgreSql.Tests.PostgreSql; namespace Strata.SqlTools.SqlBreakdown.Tests.PostgreSql;
[TestFixture] [TestFixture]
public class CommandVisitorTests public class CommandVisitorTests
@@ -24,11 +24,10 @@ public class CommandVisitorTests
{ {
var method = typeof(CommandVisitor).GetMethod( var method = typeof(CommandVisitor).GetMethod(
"FormatParameterName", "FormatParameterName",
System.Reflection.BindingFlags.Instance | System.Reflection.BindingFlags.NonPublic | System.Reflection.BindingFlags.Public) System.Reflection.BindingFlags.Instance
?? typeof(Strata.SqlTools.Visitors.SqlServer.CommandVisitor).GetMethod( | System.Reflection.BindingFlags.NonPublic
"FormatParameterName", | System.Reflection.BindingFlags.Public);
System.Reflection.BindingFlags.Instance | System.Reflection.BindingFlags.NonPublic); Assert.That(method, Is.Not.Null, "FormatParameterName must exist as a protected override on CommandVisitor");
Assert.That(method, Is.Not.Null, "FormatParameterName must exist as a protected method on the visitor hierarchy");
return (string)method!.Invoke(visitor, new object[] { name })!; return (string)method!.Invoke(visitor, new object[] { name })!;
} }
} }