chore(sonar)!: clear all 17 remaining src/ code smells #16

Merged
bermudalamb merged 3 commits from fix/sonarqube-prod-misc-17 into main 2026-05-27 15:12:02 -05:00
17 changed files with 8 additions and 69 deletions
Showing only changes of commit 423108a7dc - Show all commits
@@ -6,7 +6,7 @@ namespace Strata.SqlTools.Markdown.LinqToSql;
/// Generates Mermaid diagram markdown from LINQ to SQL QueryBreakdown objects.
/// Creates flowchart visualizations showing the LINQ query structure and flow.
/// </summary>
public class QueryBreakdownGenerator
public static class QueryBreakdownGenerator
{
/// <summary>
/// Generates a Mermaid flowchart diagram from a LINQ to SQL QueryBreakdown.
@@ -8,7 +8,7 @@ namespace Strata.SqlTools.Markdown.LinqToSql;
/// Generates Mermaid diagrams for LINQ to SQL statements, including sequence diagrams
/// for statement execution flow and entity-relationship diagrams.
/// </summary>
public class SqlStatementGenerator
public static class SqlStatementGenerator
{
/// <summary>
/// Generates a Mermaid sequence diagram showing LINQ to SQL statement execution flow.
@@ -6,7 +6,7 @@ namespace Strata.SqlTools.Markdown.PostgreSql;
/// Generates Mermaid diagram markdown from PostgreSQL SQL QueryBreakdown objects.
/// Creates flowchart visualizations showing the query structure and flow.
/// </summary>
public class QueryBreakdownGenerator
public static class QueryBreakdownGenerator
{
/// <summary>
/// Generates a Mermaid flowchart diagram from a PostgreSQL QueryBreakdown.
@@ -6,7 +6,7 @@ namespace Strata.SqlTools.Markdown.PostgreSql;
/// Generates Mermaid diagrams for PostgreSQL SQL statements, including sequence diagrams
/// for statement execution flow and entity-relationship diagrams.
/// </summary>
public class SqlStatementGenerator
public static class SqlStatementGenerator
{
/// <summary>
/// Generates a Mermaid sequence diagram showing PostgreSQL SQL statement execution flow.
@@ -6,7 +6,7 @@ namespace Strata.SqlTools.Markdown.Snowflake;
/// Generates Mermaid diagram markdown from Snowflake SQL QueryBreakdown objects.
/// Creates flowchart visualizations showing the query structure and flow.
/// </summary>
public class QueryBreakdownGenerator
public static class QueryBreakdownGenerator
{
/// <summary>
/// Generates a Mermaid flowchart diagram from a Snowflake QueryBreakdown.
@@ -6,7 +6,7 @@ namespace Strata.SqlTools.Markdown.Snowflake;
/// Generates Mermaid diagrams for Snowflake SQL statements, including sequence diagrams
/// for statement execution flow and entity-relationship diagrams.
/// </summary>
public class SqlStatementGenerator
public static class SqlStatementGenerator
{
/// <summary>
/// Generates a Mermaid sequence diagram showing Snowflake SQL statement execution flow.
@@ -8,7 +8,7 @@ namespace Strata.SqlTools.Markdown.SqlServer;
/// Generates Mermaid diagram markdown from SQL QueryBreakdown objects.
/// Creates flowchart visualizations showing the query structure and flow.
/// </summary>
public class QueryBreakdownGenerator
public static class QueryBreakdownGenerator
{
/// <summary>
/// Generates a Mermaid flowchart diagram from a QueryBreakdown.
@@ -6,7 +6,7 @@ namespace Strata.SqlTools.Markdown.SqlServer;
/// <summary>
/// Generates Mermaid sequence diagrams from SQL statements to visualize statement execution flow.
/// </summary>
public class SqlStatementGenerator
public static class SqlStatementGenerator
{
/// <summary>
/// Generates a Mermaid sequence diagram showing SQL statement execution.
@@ -6,13 +6,11 @@ namespace Strata.SqlTools.Markdown.Tests.LinqToSql;
[TestFixture]
public class QueryBreakdownGeneratorTests
{
private QueryBreakdownGenerator _generator = null!;
private TestDataContext _context = null!;
[SetUp]
public void Setup()
{
_generator = new QueryBreakdownGenerator();
_context = new TestDataContext();
}
@@ -6,14 +6,6 @@ namespace Strata.SqlTools.Markdown.Tests.LinqToSql;
[TestFixture]
public class SqlStatementGeneratorTests
{
private SqlStatementGenerator _generator = null!;
[SetUp]
public void Setup()
{
_generator = new SqlStatementGenerator();
}
[Test]
public void GenerateLinqPipelineDiagram_BasicQuery_GeneratesSequenceDiagram()
{
@@ -6,14 +6,6 @@ namespace Strata.SqlTools.Markdown.Tests.PostgreSql;
[TestFixture]
public class QueryBreakdownGeneratorTests
{
private QueryBreakdownGenerator _generator = null!;
[SetUp]
public void Setup()
{
_generator = new QueryBreakdownGenerator();
}
[Test]
public void GenerateMermaidDiagram_SimplePostgreSqlQuery_GeneratesValidMermaid()
{
@@ -6,14 +6,6 @@ namespace Strata.SqlTools.Markdown.Tests.PostgreSql;
[TestFixture]
public class SqlStatementGeneratorTests
{
private SqlStatementGenerator _generator = null!;
[SetUp]
public void Setup()
{
_generator = new SqlStatementGenerator();
}
[Test]
public void GenerateSequenceDiagram_PostgreSqlQuery_GeneratesValidDiagram()
{
@@ -6,14 +6,6 @@ namespace Strata.SqlTools.Markdown.Tests.Snowflake;
[TestFixture]
public class QueryBreakdownGeneratorTests
{
private QueryBreakdownGenerator _generator = null!;
[SetUp]
public void Setup()
{
_generator = new QueryBreakdownGenerator();
}
[Test]
public void GenerateMermaidDiagram_SimpleSnowflakeQuery_GeneratesValidMermaid()
{
@@ -6,14 +6,6 @@ namespace Strata.SqlTools.Markdown.Tests.Snowflake;
[TestFixture]
public class SqlStatementGeneratorTests
{
private SqlStatementGenerator _generator = null!;
[SetUp]
public void Setup()
{
_generator = new SqlStatementGenerator();
}
[Test]
public void GenerateSequenceDiagram_SnowflakeQuery_GeneratesValidDiagram()
{
@@ -7,14 +7,6 @@ namespace Strata.SqlTools.Markdown.Tests.SqlServer;
[TestFixture]
public class QueryBreakdownGeneratorTests
{
private QueryBreakdownGenerator _generator = null!;
[SetUp]
public void Setup()
{
_generator = new QueryBreakdownGenerator();
}
[Test]
public void GenerateMermaidDiagram_WithSimpleQuery_GeneratesFlowchart()
{
@@ -8,15 +8,12 @@ namespace Strata.SqlTools.Markdown.Tests.SqlServer;
[Category("MarkdownGeneration")]
public class QueryMarkdownGenerationTests
{
private QueryBreakdownGenerator _generator = null!;
private string _queriesSourcePath = null!;
private string _markdownOutputPath = null!;
[SetUp]
public void Setup()
{
_generator = new QueryBreakdownGenerator();
// Get the solution root directory
var testDirectory = TestContext.CurrentContext.TestDirectory;
var solutionRoot = Directory.GetParent(testDirectory)?.Parent?.Parent?.Parent?.Parent?.FullName;
@@ -6,14 +6,6 @@ namespace Strata.SqlTools.Markdown.Tests.SqlServer;
[TestFixture]
public class SqlStatementGeneratorTests
{
private SqlStatementGenerator _generator = null!;
[SetUp]
public void Setup()
{
_generator = new SqlStatementGenerator();
}
[Test]
public void GenerateSequenceDiagram_WithSimpleQuery_GeneratesSequence()
{