6 Commits

Include renames

Author	SHA1	Message	Date
Thom LambandClaude Opus 4.7	470cb009b9	chore(sonar): cache JsonSerializerOptions in test fixture (CA1869) ... Promote the `new JsonSerializerOptions { Converters = { ... } }` instance that `OneTimeSetup` was constructing on each fixture run to a `private static readonly JsonSerializerOptions _jsonOptions` field, so the converter list isn't rebuilt per fixture. Strictly cosmetic here (OneTimeSetup runs once) but it's the change the analyzer wants and the field is the more idiomatic JsonSerializer pattern. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-27 12:02:25 -05:00
Thom LambandClaude Opus 4.7	67512d23e1	chore(sonar): wrap independent assertions in Assert.Multiple (NUnit2045) ... Driven by `dotnet format analyzers --diagnostics NUnit2045`. The fixer groups consecutive independent `Assert.That(...)` calls into `Assert.Multiple(() => { ... })`, so a failing assertion no longer short-circuits the block — every failure inside the group is reported, which gives much better diagnostics on multi-property tests. Audit confirmed no Assert.Throws / Assert.Fail / Assert.Catch / Assert.Pass / Assert.DoesNotThrow got pulled inside a Multiple block (those need to short-circuit). All 1180 tests pass. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-27 11:59:47 -05:00
Thom LambandClaude Opus 4.7	6af239035b	chore(sonar): use concrete return types where binary-safe (CA1859) ... CA1859 has no `dotnet format` batch fixer, so applied manually after verifying each site is private/internal/test (no public-surface impact): - Markdown.TryParseLogicalOperation: Expression? -> BoolExpr? (private) - Markdown.TryParseComparison: Expression? -> Comparison? (private) - RuleSet.GetAllSingleRules(IGroup): IEnumerable<SingleRule> -> List<SingleRule> (private overload) - SqlExpressionClause.SplitOnComma: IEnumerable<string> -> List<string> (private) - QueryBreakdownRepositoryTests._repository: IQueryBreakdownRepository -> QueryBreakdownRepository (test private field) - UnitTest1.StartsWith(...,string): Expression -> MethodCallExpression (test private helper) The public `RuleSet.GetAllSingleRules()` overload still returns IEnumerable<SingleRule> — only the private recursive helper was tightened. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-26 15:49:20 -05:00
Thom LambandClaude Opus 4.7	2c2a8b1193	chore(sonar): bulk-fix mechanical CA/IDE analyzer warnings ... Applied via `dotnet format analyzers --diagnostics IDE0028 CA1825 CA1834 CA1845 CA1847 CA1860 CA1866 CA1853 CA1830 CA1846 CA1806 CA1869 CA2249 --severity info`. 19 files touched, all mechanical syntactic rewrites: - CA1847: string.Contains("x") -> string.Contains('x') - CA2249: s.IndexOf(c) == -1 -> !s.Contains(c) - CA1830: sb.Append(sb.ToString()) -> sb.Append(sb) - CA1834: StringBuilder.Append("x") -> Append('x') - CA1825, CA1860, CA1866, CA1853, IDE0028, CA1845: corresponding fixers Three rules in the batch had no batch fixer available (CA1846 ×4, CA1806 ×1, CA1869 ×1) and stay open for separate manual handling. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-26 15:38:54 -05:00
bermudalamb	79879c62b4	Update tests/Strata.SqlTools.Rules.Tests/Strata.SqlTools.Rules.Tests.csproj	2026-05-15 13:26:23 -05:00
Thom Lamb	5e467bcc9c	chore: initial git load of code space	2026-05-12 08:52:33 -05:00