5 Commits

Include renames

Author	SHA1	Message	Date
Thom LambandClaude Opus 4.7	f55d8130e6	chore(sonar): clear residual test-file smells (NUnit2046, NUnit2045, CS8604) ... - **NUnit2046 (15)**: extend the prior regex sweep to also catch the `Is.GreaterThan(n)` / `Is.GreaterThanOrEqualTo(n)` variants on `.Count` and `.Length` — the previous pass only handled `Is.EqualTo`. Affects PG/Snowflake `QueryBreakdownTests`, PG `StatementReaderTests`, `LinqToSql` `QueryComparatorTests` / `QueryValidatorTests`, `Markdown.Tests` `ExpressionGeneratorTests` / `QueryBreakdownGeneratorTests`, and `JsonTokenReaderTests`. - **CS8604 (8)**: `merged[someKey]` access inside `Assert.Multiple(() => { ... })` lambdas where `someKey` is `string?` from `FirstOrDefault`. The preceding `Assert.That(someKey, Is.Not.Null)` does not propagate null-narrowing into the lambda scope, so add `!` to the dictionary index. (Tests fail loud with a meaningful message if the key really is null, so this is safe.) - **NUnit2045 (1)**: wrap a four-assert block in `JsonTokenReaderTests.cs:65-68` in `Assert.Multiple`. Mirrors the surrounding two `Assert.Multiple` groups in that method. All 1180 tests stay green. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-27 15:29:20 -05:00
Thom LambandClaude Opus 4.7	67512d23e1	chore(sonar): wrap independent assertions in Assert.Multiple (NUnit2045) ... Driven by `dotnet format analyzers --diagnostics NUnit2045`. The fixer groups consecutive independent `Assert.That(...)` calls into `Assert.Multiple(() => { ... })`, so a failing assertion no longer short-circuits the block — every failure inside the group is reported, which gives much better diagnostics on multi-property tests. Audit confirmed no Assert.Throws / Assert.Fail / Assert.Catch / Assert.Pass / Assert.DoesNotThrow got pulled inside a Multiple block (those need to short-circuit). All 1180 tests pass. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-27 11:59:47 -05:00
Thom LambandClaude Opus 4.7	505ada5017	chore(sonar): adopt Has.Count, Is.Empty, Does.Contain, char overloads in tests (NUnit2046, NUnit2011, CA1866) ... - NUnit2046: `Assert.That(x.Count, Is.EqualTo(n))` → `Assert.That(x, Has.Count.EqualTo(n))` (or `Is.Empty` when n==0) - NUnit2011: `Assert.That(s.Contains(x))` → `Assert.That(s, Does.Contain(x))` for richer failure messages - CA1866: `.StartsWith("$"|"@"|":")` → `.StartsWith('$'|'@'|':')` char overload Driven by `dotnet format analyzers --diagnostics NUnit2046 NUnit2011 CA1866` for the cases the Roslyn fixer handles, plus a regex sweep for the remaining `Count == n` (n>0) cases which the fixer doesn't address. CA1866 had no associated code fix and was edited by hand (3 sites in 2 files). All tests green (1180 passing). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-27 11:58:00 -05:00
Thom LambandClaude Opus 4.7	2c2a8b1193	chore(sonar): bulk-fix mechanical CA/IDE analyzer warnings ... Applied via `dotnet format analyzers --diagnostics IDE0028 CA1825 CA1834 CA1845 CA1847 CA1860 CA1866 CA1853 CA1830 CA1846 CA1806 CA1869 CA2249 --severity info`. 19 files touched, all mechanical syntactic rewrites: - CA1847: string.Contains("x") -> string.Contains('x') - CA2249: s.IndexOf(c) == -1 -> !s.Contains(c) - CA1830: sb.Append(sb.ToString()) -> sb.Append(sb) - CA1834: StringBuilder.Append("x") -> Append('x') - CA1825, CA1860, CA1866, CA1853, IDE0028, CA1845: corresponding fixers Three rules in the batch had no batch fixer available (CA1846 ×4, CA1806 ×1, CA1869 ×1) and stay open for separate manual handling. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-26 15:38:54 -05:00
Thom Lamb	5e467bcc9c	chore: initial git load of code space	2026-05-12 08:52:33 -05:00