6 Commits

Include renames

Author	SHA1	Message	Date
bermudalamb	f362ec7e53	Merge pull request 'chore(sonar): clear a code smell' (#19) from chore/ci-coverage-reporting into main ... Reviewed-on: #19	2026-05-27 15:51:13 -05:00
Thom Lamb	39f1d30783	chore(sonar): clear a code smell	2026-05-27 15:50:03 -05:00
Thom LambandClaude Opus 4.7	f55d8130e6	chore(sonar): clear residual test-file smells (NUnit2046, NUnit2045, CS8604) ... - **NUnit2046 (15)**: extend the prior regex sweep to also catch the `Is.GreaterThan(n)` / `Is.GreaterThanOrEqualTo(n)` variants on `.Count` and `.Length` — the previous pass only handled `Is.EqualTo`. Affects PG/Snowflake `QueryBreakdownTests`, PG `StatementReaderTests`, `LinqToSql` `QueryComparatorTests` / `QueryValidatorTests`, `Markdown.Tests` `ExpressionGeneratorTests` / `QueryBreakdownGeneratorTests`, and `JsonTokenReaderTests`. - **CS8604 (8)**: `merged[someKey]` access inside `Assert.Multiple(() => { ... })` lambdas where `someKey` is `string?` from `FirstOrDefault`. The preceding `Assert.That(someKey, Is.Not.Null)` does not propagate null-narrowing into the lambda scope, so add `!` to the dictionary index. (Tests fail loud with a meaningful message if the key really is null, so this is safe.) - **NUnit2045 (1)**: wrap a four-assert block in `JsonTokenReaderTests.cs:65-68` in `Assert.Multiple`. Mirrors the surrounding two `Assert.Multiple` groups in that method. All 1180 tests stay green. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-27 15:29:20 -05:00
Thom LambandClaude Opus 4.7	4fe9eb36e6	chore(sonar): second sweep — catch .Length, Is.Not.Empty, and newly-exposed Multiple groups (NUnit2046, NUnit2045) ... Re-runs `dotnet format analyzers --diagnostics NUnit2046 NUnit2045` after the Tier 2 Assert.Multiple wrap, which exposed: - `Has.Length.EqualTo(n)` rewrites for `string[]`/array `.Length` checks (the first pass only knew about `.Count`). - `Is.Not.Empty` rewrites for `Count, Is.GreaterThan(0)`. - A handful of new NUnit2045 groups that became wrappable once the initial Multiple blocks settled the surrounding indentation. Tests still 1180/1180 passing. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-27 12:14:13 -05:00
Thom LambandClaude Opus 4.7	67512d23e1	chore(sonar): wrap independent assertions in Assert.Multiple (NUnit2045) ... Driven by `dotnet format analyzers --diagnostics NUnit2045`. The fixer groups consecutive independent `Assert.That(...)` calls into `Assert.Multiple(() => { ... })`, so a failing assertion no longer short-circuits the block — every failure inside the group is reported, which gives much better diagnostics on multi-property tests. Audit confirmed no Assert.Throws / Assert.Fail / Assert.Catch / Assert.Pass / Assert.DoesNotThrow got pulled inside a Multiple block (those need to short-circuit). All 1180 tests pass. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-27 11:59:47 -05:00
Thom Lamb	8b0368e810	test: fix SqlBreakdown tests project	2026-05-15 13:39:14 -05:00