Commit Graph
3 Commits
Author SHA1 Message Date
Thom LambandClaude Opus 4.7 c38d122d76 docs(skill): rewrite sonarqube cleanup section around tiered bulk fixes
SonarQube Analysis / sonarqube (pull_request) Successful in 2m51s
Section A (server inspection / API access) is unchanged. Section B is
rewritten around the tiered model:

- Tier 1 — mechanical: bulk fix multiple rule IDs in one dotnet format
  invocation (IDE0028, CA1825, CA1834, etc).
- Tier 2 — judgment: one commit per rule, audit diff before staging.
  Calls out CA1822 public-static = binary break, CA1861 cryptic
  generated field names + duplicate-field collisions, CA1859 has no
  batch fixer.
- Tier 3 — manual / no fixer: csharpsquid:Sxxxx, public-API design
  calls. Reference [[sonarqube-wontfix-rules]] memory for triage.

Adds the local-Java-version gotcha: `./scan-sonar.ps1` is blocked here
(system JRE is 8, scanner needs 17); CI handles the upload via
actions/setup-java@v4 with temurin 17.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-26 15:50:25 -05:00
Thom LambandClaude Opus 4.7 d92996bd2e docs(skill): add sonarqube cleanup + inspection skill
Codifies (A) how to query the bermudalamb SonarQube 9.9 server's web API
from PowerShell — Basic auth with token-as-username, the
SONARQUBE_URL trailing-slash gotcha, the useful endpoints for triage and
Won't Fix transitions; and (B) the per-rule-group cleanup loop (query →
pick → edit → build → test → commit → scan → verify).

References memory sonarqube-wontfix-rules rather than duplicating the
catalog. Frontmatter follows superpowers:writing-skills (description is
triggering conditions only, no workflow summary).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-26 09:34:44 -05:00
Thom LambandClaude Opus 4.7 1124e91141 chore(sonar): remove three unused local variables (S1481)
- LinqQueryBreakdown.cs:211 - drop unused `expr` pattern binding (type test remains)
- LinqQueryBreakdown.cs:279 - drop unused `firstEntity` (empty check already above)
- LinqExpressionVisitor.cs:315 - drop unused `param` pattern binding

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-26 09:25:34 -05:00