5 Commits

Include renames

Author	SHA1	Message	Date
Thom LambandClaude Opus 4.7	c121dfa611	refactor(dedup): share TryParse prelude across breakdown families (Cluster D) ... The standard `TryParse(...)` prelude — null/empty check, parser construction, comment-preserving normalize, statement-prefix regex validation, setup/finish clause extraction — was copy-pasted in **eight** breakdown classes across the SqlServer and Snowflake dialects. Sonar flagged it as a six-way duplicate cluster on the shorter (~17-line) common block, and as additional pairwise duplicates on the longer (~30-line) version. Introduces `Strata.SqlTools.Statements.SqlServer.ParsePreparation` with a single `TryRunPrelude(sql, parser, prefixRegex, prefixDescription, out ...)` method. Each `TryParse` now calls it once and proceeds straight to dialect-specific match logic. Touched callers: - `SqlServer.InsertBreakdown`, `SqlServer.DeleteBreakdown`, `SqlServer.UpdateBreakdown`, `SqlServer.ProcedureBreakdown` - `Snowflake.InsertBreakdown`, `Snowflake.DeleteBreakdown`, `Snowflake.UpdateBreakdown`, `Snowflake.ProcedureBreakdown` The Microsoft-SQL fallback path in the Snowflake breakdowns (which delegates to the SqlServer breakdown's TryParse before the prelude even runs) is preserved unchanged. `ParsePreparation` is `public` because it sits in the SqlServer assembly and is consumed cross-assembly by Snowflake/PostgreSql. This is a new public type but it's deliberately a thin scaffold — external consumers should still be calling the breakdown classes' own `TryParse` methods. All 1180 tests stay green. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-27 16:33:43 -05:00
Thom LambandClaude Opus 4.7	0f8d505616	chore(sonar): apply collection-expression syntax across all sites (IDE0028) ... Manual sweep of all 42 IDE0028 sites flagged by SonarQube — `dotnet format analyzers --diagnostics IDE0028` declined to fix these (no .editorconfig opt-in for `dotnet_style_prefer_collection_expression`), so applied by hand. The repo already targets `<LangVersion>latest</LangVersion>` on net8.0, so C# 12 collection expressions are available. Pattern: `new List<T>()` / `new Dictionary<K,V>()` / `new ArrayList()` / `new()` -> `[]` for empty; `new List<T> { ... }` -> `[...]` for literal. 24 files touched in src/{EFCore, LinqToSql, Query, Snowflake, SqlBreakdown, SqlServer}; tests untouched (no IDE0028 sites in test code). Build clean (35 warnings unchanged from baseline, 0 errors). All tests remain green. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-26 17:01:30 -05:00
Thom Lamb	2d9148547f	fix(serialization): Remove legacy BinaryFormatter support ... The `[Serializable]` attribute and corresponding `[OnDeserialized]` methods have been removed from various breakdown classes. This eliminates reliance on `BinaryFormatter`, which is a deprecated and insecure serialization mechanism in modern .NET. This change also resolves SonarQube rule S5766 warnings by removing the context in which they apply, leading to cleaner and more secure code.	2026-05-20 17:44:21 -05:00
Thom Lamb	e3153e58c4	fix(security): Resolve SonarQube security hotspots ... Introduce a default regex match timeout across the library to prevent potential ReDoS attacks (SonarQube rule S6444). Implement `[OnDeserialized]` methods to re-establish object invariants and validate state after deserialization, addressing SonarQube rule S5766.	2026-05-20 17:19:17 -05:00
Thom Lamb	5e467bcc9c	chore: initial git load of code space	2026-05-12 08:52:33 -05:00