6 Commits

Include renames

Author	SHA1	Message	Date
Thom LambandClaude Opus 4.7	505ada5017	chore(sonar): adopt Has.Count, Is.Empty, Does.Contain, char overloads in tests (NUnit2046, NUnit2011, CA1866) ... - NUnit2046: `Assert.That(x.Count, Is.EqualTo(n))` → `Assert.That(x, Has.Count.EqualTo(n))` (or `Is.Empty` when n==0) - NUnit2011: `Assert.That(s.Contains(x))` → `Assert.That(s, Does.Contain(x))` for richer failure messages - CA1866: `.StartsWith("$"|"@"|":")` → `.StartsWith('$'|'@'|':')` char overload Driven by `dotnet format analyzers --diagnostics NUnit2046 NUnit2011 CA1866` for the cases the Roslyn fixer handles, plus a regex sweep for the remaining `Count == n` (n>0) cases which the fixer doesn't address. CA1866 had no associated code fix and was edited by hand (3 sites in 2 files). All tests green (1180 passing). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-27 11:58:00 -05:00
Thom LambandClaude Opus 4.7	f5d539b906	chore(sonar): hoist constant array literals to static readonly fields (CA1861) ... Applied via `dotnet format analyzers --diagnostics CA1861 --severity info`, plus manual cleanup: - Renamed two cryptic fixer-generated field names: - QueryBreakdownCollection.stringArray -> SnowflakeFunctionNames (and inlined the now-redundant local alias) - ExpressionObjectTests.arg2 -> NotInValues - Deduped three identical `separator = ['\r','\n']` fields the fixer emitted in the same test class (kept the first declaration; the other two test methods now reuse it). 8 files touched. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-26 15:45:16 -05:00
Thom LambandClaude Opus 4.7	84b06557e5	chore(sonar)!: mark instance-data-free members static (CA1822) ... Applied via `dotnet format analyzers --diagnostics CA1822 --severity info`. 12 files touched. The fixer also updated internal callers in tests to use the type-name form (e.g. `gen.Method(x)` -> `Generator.Method(x)`); build and full test suite remain green. BREAKING CHANGE: two public methods become static and therefore can no longer be invoked through an instance reference by external consumers: - Strata.SqlTools.Markdown.LinqToSql.QueryBreakdownGenerator.GenerateMethodChainDiagram - Strata.SqlTools.Markdown.LinqToSql.SqlStatementGenerator.GenerateLinqPipelineDiagram Both are stateless utility methods on Generator classes — the static form is the correct shape; the only callers in this repo already used the type-name form. External code should change `gen.GenerateMethodChainDiagram(...)` to `QueryBreakdownGenerator.GenerateMethodChainDiagram(...)`. All other CA1822 hits in this commit are on private/protected members (no public-surface impact). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-26 15:41:46 -05:00
Thom LambandClaude Opus 4.7	2c2a8b1193	chore(sonar): bulk-fix mechanical CA/IDE analyzer warnings ... Applied via `dotnet format analyzers --diagnostics IDE0028 CA1825 CA1834 CA1845 CA1847 CA1860 CA1866 CA1853 CA1830 CA1846 CA1806 CA1869 CA2249 --severity info`. 19 files touched, all mechanical syntactic rewrites: - CA1847: string.Contains("x") -> string.Contains('x') - CA2249: s.IndexOf(c) == -1 -> !s.Contains(c) - CA1830: sb.Append(sb.ToString()) -> sb.Append(sb) - CA1834: StringBuilder.Append("x") -> Append('x') - CA1825, CA1860, CA1866, CA1853, IDE0028, CA1845: corresponding fixers Three rules in the batch had no batch fixer available (CA1846 ×4, CA1806 ×1, CA1869 ×1) and stay open for separate manual handling. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-26 15:38:54 -05:00
Thom LambandClaude Opus 4.7	5cb32d2311	refactor(query): extract shared Strata.SqlTools.Query model project ... Moves the byte-identical 19-file ExpressionFactory/Query tree (duplicated across Snowflake and SqlServer) into the new Strata.SqlTools.Query project under the flat namespace Strata.SqlTools.Query. Both dialect projects now reference the shared project; the Snowflake copies are deleted. Also folds in the IDE0028 fix on CalculationFilterGroup.GetValidFilters (collection expression []), which resolves both new-code IDE0028 smells in one place now that there is a single copy. Eliminates the 63 new duplicate lines flagged on the PR and removes the largest contributor to the project's 11.1% duplication density. No behavioral change: the moved types are identical to the originals. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-20 12:04:01 -05:00
Thom Lamb	8b0368e810	test: fix SqlBreakdown tests project	2026-05-15 13:39:14 -05:00